02:09.55 | *** join/#wowroster Nickthestick86 (n=Nickthes@64-148-244-255.lightspeed.snantx.sbcglobal.net) |
02:10.08 | Nickthestick86 | anyone here? I got a question |
02:56.53 | Anaxent | check out the new trailer for BC http://infragilisguild.com/index.php?name=ForumsPro&file=viewtopic&p=381#381 |
05:34.49 | *** join/#wowroster Anaxent (n=Anaxent@ip68-3-142-242.ph.ph.cox.net) |
05:34.49 | *** mode/#wowroster [+o Anaxent] by ChanServ |
05:35.10 | Anaxent | whats up guys |
06:13.02 | Zanix|away | hi |
06:13.17 | Zanix | too bad I missed chris |
06:35.39 | *** join/#wowroster Zanix_ (n=Zanix@71-221-151-133.bois.qwest.net) |
07:15.28 | *** mode/#wowroster [+o Zanix] by ChanServ |
07:17.15 | Anaxent | yes it is too bad, but mathos was here for a bit and PleegWat got alot acrossed |
07:17.53 | Anaxent | and if you have logs in dev chan you can see |
07:18.17 | Anaxent | PleegWat, has made the changes needed to get the framework working with no errors |
07:19.54 | Zanix | cool |
07:22.28 | Anaxent | so how were pictures |
07:27.09 | Anaxent | I had to take them last week |
07:27.19 | Anaxent | http://infragilisguild.com/index.php?name=ForumsPro&file=viewtopic&t=137 |
07:28.12 | Zanix | Ive seen that vid |
07:39.21 | Zanix | coolness |
08:14.10 | *** join/#wowroster Orphis (n=Orphis@sop06-1-82-228-251-21.fbx.proxad.net) |
09:26.11 | *** join/#wowroster Zanix_ (n=Zanix@71-221-151-133.bois.qwest.net) |
09:32.01 | *** mode/#wowroster [+o Zanix] by ChanServ |
12:49.09 | Liandra | hm, interesting: http://serenityguild.eu/roster-beta/addon.php?roster_addon_name=recipe&proffilter=Engineering&filterbox=bomb |
12:49.21 | Liandra | some recipes are there twice |
12:49.29 | Liandra | with the ingredients in a different order |
13:07.38 | PleegWat | I notice |
13:07.51 | PleegWat | Noone really knows how recipe works though |
13:08.26 | PleegWat | It's probably a data issue basically. Different persons having it, and it's stored for each one |
13:08.31 | PleegWat | and not all with the same recipe order |
13:10.28 | Liandra | could you alphabetise the ingredients then? that might help |
13:10.54 | Liandra | either in CharacterProfiler.lua or in the db/website :) |
13:11.28 | PleegWat | The ingredients are caught in a string |
13:11.38 | Liandra | ah, that makes it a bit harder |
13:11.46 | PleegWat | Or at least, they used to be in a single tring in CP |
13:11.53 | PleegWat | They're in an array starting 2.0 |
13:12.06 | PleegWat | But we're converting back to string for 1.7.2 to save on code rewrites |
13:12.46 | Liandra | could you order the array by something (alphabet?) in CP 2.0? |
13:13.25 | Liandra | that might fix iths |
13:13.26 | PleegWat | We probably could order it, but that wouldn't help with all the current data in the system |
13:15.46 | PleegWat | Yeah, we're currently still storing it in the order CP catches it |
13:16.09 | PleegWat | Ordering it probably wouldn't fix the bug completely and as I said noone really knows how recipe works anymore |
13:16.16 | PleegWat | Expect it fixed in R2 |
13:16.27 | PleegWat | cause that's a full rewrite |
13:16.32 | Liandra | ok, sounds good |
13:16.36 | Liandra | just trying to help out here :) |
13:18.13 | PleegWat | Meanwhile you could try going into phpmyadmin and manually fixing the recipes so all records with the same recipe name have the same tooltip/reagents |
13:19.52 | Liandra | not going to bother with that; just playing around with the beta now, and when the new version is released, i'll throw everything away and install a fresh roster |
13:20.17 | PleegWat | ic |
13:20.37 | Liandra | as Anaxent recommended, since there won't be a beta -> release automatic upgrade path :) |
13:23.46 | Liandra | i can't find any pattern in which items do have a full tooltip and which items don't, in http://www.serenityguild.eu/roster-beta/addon.php?roster_addon_name=equipview |
13:23.58 | PleegWat | Neither can us and calvin |
13:24.01 | PleegWat | It's a CP error |
13:24.04 | PleegWat | That's about all we know |
13:24.34 | Liandra | is the tooltip data exported from the game to the database and used from there? |
13:24.41 | PleegWat | yes |
13:24.54 | Liandra | so not retrieved from an external source based on item name |
13:25.01 | PleegWat | no |
13:25.05 | PleegWat | It's caught from the game |
13:25.18 | Liandra | too bad i don't have my CharacterProfiler.lua datafile here at work |
13:30.37 | PleegWat | Let's see if I've got you some recipe data |
13:31.42 | PleegWat | Sorry, I don't have any recipe data yet |
13:34.24 | Liandra | mysql> select * from roster_recipes limit 1\G |
13:34.28 | Liandra | <PROTECTED> |
13:34.46 | Liandra | should be able to split that by <br> and order it alphabetically, i guess? |
13:35.19 | PleegWat | yeah |
13:35.26 | PleegWat | Not sure if mysql can do taht |
13:35.42 | PleegWat | Would take some work if you have to loop all records through PHP |
13:36.08 | Liandra | well, cough, with a proper table layout, mysql could do it for you :) |
13:36.22 | Liandra | but like this, no |
13:36.30 | PleegWat | It always used to be a string |
13:36.40 | PleegWat | Most probably it'll be a seperate table in 2.0 |
13:36.57 | PleegWat | We're dealing with inconsistent static data at time |
13:37.15 | PleegWat | But hopefully we'll be able to store static data only once in seperate tables in 2.0 |
13:39.42 | Liandra | hrm, this is weird |
13:39.43 | Liandra | http://serenityguild.eu/bomb.txt |
13:40.10 | PleegWat | It'll be pulling DISTINCT records without the member_id |
13:40.32 | Liandra | what is the reason that there is no unique constraint (if there's such a thing) on recipe_name? |
13:40.59 | PleegWat | $query= "SELECT distinct recipe_tooltip, recipe_name, recipe_type, item_color, skill_name, reagents, recipe_texture, level, 1 difficulty FROM `".ROSTER_RECIPESTABLE."` WHERE `skill_name` = '$skill_name' ".($search==''?'':" AND (recipe_tooltip LIKE '%".$search."%' OR recipe_name LIKE '%".$search."%')"); |
13:41.22 | PleegWat | It's stored completely seperately per character |
13:41.32 | PleegWat | Dunno the history |
13:41.56 | PleegWat | But every character in roster 1x has a complete personal set of data |
13:41.59 | Liandra | it sounds highly unlikely that there could be identical recipe_name rows with different ingredients |
13:42.07 | PleegWat | Besides the guild table everything is keyed on member_id |
13:42.34 | PleegWat | The query I pasted is the one used to fetch recipes |
13:43.08 | PleegWat | it's in lib/recipes.php |
13:43.29 | PleegWat | It might be possible to fiddle with it so it only returns each recipe name once |
13:43.41 | Liandra | sounds like bad database design if you need 'distinct' to make sure recipes are unique |
13:44.01 | PleegWat | It is |
13:44.02 | Liandra | one should check if there is a recipe with that name already before inserting a recipe :) |
13:44.14 | PleegWat | That just isn't how the system was built |
13:44.15 | Liandra | what if you remove "reagents, " from that query? |
13:44.20 | PleegWat | It stores the recipe keyed on character |
13:44.20 | Liandra | oh wait, i can try that myself |
13:44.35 | PleegWat | You'll get errors cause it requests the reagents later on |
13:44.51 | Liandra | hrmph |
13:45.03 | Liandra | it should get the reagents, but not use them for distinct |
13:45.27 | PleegWat | probably |
13:45.27 | Liandra | can you do SELECT reagents, DISTINCT <other stuff> FROM ... ? |
13:45.34 | PleegWat | But I'm not sure waht the syntax is |
13:47.07 | PleegWat | I THINK you can do distinct over a single field |
13:49.08 | PleegWat | but it doesn't seem to be in the mysql manual |
13:49.38 | PleegWat | You could fetch the reagents afterward probably |
13:50.29 | Liandra | in the code, how do you access a value in a resultset from a query? by name of the column? |
13:51.02 | PleegWat | yes |
13:51.19 | Liandra | phew, so i can rearrange the columns in the SELECT without the code breaking |
13:51.28 | PleegWat | Well, actually there are 2 fetch methods. One allows you to fetch by name, the other by the index in the SELECT |
13:51.31 | PleegWat | But we always use the name |
13:51.50 | Liandra | /pat :) |
13:52.16 | Liandra | i tried SELECT reagents, DISTINCT <the rest of the query> but that gave a SQL error :( |
13:52.34 | PleegWat | Try DISTINCT(recipe_name),<the rest> |
13:53.56 | Liandra | no cookies |
13:54.16 | PleegWat | I think you're gonna need subqueries then |
13:54.22 | PleegWat | Tried not fetching the reagents at all yet? |
13:54.56 | PleegWat | We definitely need static data tables in R2 |
13:54.58 | Liandra | a colleague suggests starting by SELECT DISTINCT recipe_name INTO temptable; and then using that temp table |
13:55.16 | Liandra | what exactly do you mean by static data tables? |
13:55.32 | PleegWat | Might be better to say environment data |
13:55.43 | Liandra | how is that data obtained/updated? |
13:55.45 | PleegWat | Split stuff that only changes in patches from stuff that changes allt he time |
13:55.53 | Liandra | metadata :) |
13:55.55 | PleegWat | It's all from CP in the end |
13:56.06 | Liandra | but yes, that sounds good |
13:56.23 | Liandra | treat some CP data as (almost) static, and the rest as highly volatile |
13:56.25 | PleegWat | But not store all recipes each character has, but have a recipe table with all recipes we've ver seen |
13:56.37 | PleegWat | But cause of bad data and changing data, you'd need to account for differences |
13:56.56 | Liandra | Mooncloth Bag recipe changing from 2 mooncloth needed to 1 mooncloth needed |
13:57.01 | PleegWat | yeah |
13:57.15 | PleegWat | And a guy with bad data stating it needs 2 runecloth |
13:57.31 | Liandra | user accounts could help in that |
13:57.49 | Liandra | if a user account with the "trusted" flag uploads new 'static' data, the old version is overwritten |
13:57.55 | Liandra | for example |
13:58.21 | PleegWat | I'd been thinking myself of storing 2-5 examples of each and use a scoring system to determine what is relyable data |
13:59.18 | Liandra | sounds good too, if you can get it to work :) |
14:01.28 | Liandra | more stable too, if you have enough people uploading the correct data |
14:02.04 | PleegWat | hopefully |
14:06.38 | Liandra | personally, I'd probably make one table with items, one table with recipes, and one connecting table with recipe_id, item_id, count |
14:06.57 | Liandra | to solve this particular problem |
14:06.59 | PleegWat | For reagents? |
14:07.04 | PleegWat | We'd probably would |
14:07.13 | PleegWat | The new reagent array includes item_id's, I think |
14:07.17 | Liandra | the item table would hold reagents, but also all other items |
14:07.36 | PleegWat | course |
14:07.52 | Liandra | there are some recipes which require another crafted item, to upgrade it |
14:07.57 | Liandra | Onyxia's Cloak for example |
14:07.59 | PleegWat | The problematic thing is how to do skills properly |
14:08.09 | PleegWat | Cause skills can change with talents, and the numbers change in the tooltips too |
14:08.28 | Liandra | skills, like Heroic Strike and Fireball? |
14:08.46 | PleegWat | Basically we'd be building a small thottbot or allakhazam with items and recipes. |
14:09.02 | PleegWat | But we wouldn't be able to be unique on skills that change with talents without hardcoding talents. |
14:09.14 | PleegWat | And hardcoding is something we definitely don't want |
14:10.55 | PleegWat | Well, we could put the whole talent build into the skill's unique field but we don't want that either |
14:12.13 | Liandra | fixed! |
14:12.15 | Liandra | well, patched |
14:12.50 | PleegWat | how'd you do it? |
14:13.11 | Liandra | i inserted this line on line 122 of recipe.php: |
14:13.11 | Liandra | $query .= " GROUP BY recipe_name"; |
14:13.18 | Liandra | before the switch($sort) |
14:13.26 | PleegWat | hm |
14:13.30 | Liandra | but that's a dirty mysql hack which should not be recommended |
14:13.42 | Liandra | because mysql chooses a random row of all the ones with the same recipe_name |
14:13.45 | PleegWat | yeah, it did say in the mysql that DISTINCT is processed with group by |
14:13.55 | PleegWat | yeah, but since the rows should be unique anyway |
14:13.59 | Liandra | this is not valid SQL, it only works in MySQL |
14:14.10 | Liandra | if you migrate to postgres, pg will tell you to sod off :) |
14:14.10 | PleegWat | If it works in 1.7.2 it's fine with me |
14:14.44 | Liandra | http://www.serenityguild.eu/roster-beta/addon.php?roster_addon_name=recipe&proffilter=Engineering&filterbox=bomb |
14:19.14 | Liandra | well, it works for a mysql backend |
14:19.49 | PleegWat | we're rewriting for R2. That will hopefully need less hacks for being set up better |
14:25.13 | Liandra | if i can help out with any design stuff, i'll be glad to help |
14:25.21 | Liandra | but currently i don't really have any time for coding |
14:26.54 | PleegWat | Well, theres some decisions already made, mainly about the volatile data |
14:26.59 | PleegWat | We'll be doing multiguild |
14:27.26 | PleegWat | We'll split the guild member table in 2, one for generic character data and one that is specific to the guild membership |
14:28.35 | PleegWat | Then all sorts of character data can go into the char table, including PUG raid group joiners and PVP opponents if there's addons that get that data |
14:40.50 | Liandra | sounds good |
14:41.03 | Liandra | i'm a bit afraid for one thing though |
14:41.33 | Liandra | malevolent people who edit their CharacterProfiler.lua data file and change their player name into someone else's |
14:47.22 | PleegWat | That could be a problem now |
14:47.26 | PleegWat | But R2 will have auth |
14:48.07 | *** join/#wowroster Sylphid|work (n=gamesand@64.6.15.110.outfitters.com) |
15:31.46 | *** join/#wowroster Mathos (n=Mathos@mail.smtware.com) |
15:31.46 | *** mode/#wowroster [+o Mathos] by ChanServ |
15:34.16 | *** join/#wowroster Mathos (n=Mathos@mail.smtware.com) |
15:34.16 | *** mode/#wowroster [+o Mathos] by ChanServ |
16:25.59 | *** join/#wowroster Anaxent (n=Anaxent@209-250-16-194.convergentaz.net) |
16:25.59 | *** mode/#wowroster [+o Anaxent] by ChanServ |
16:26.19 | Anaxent | good morning |
17:56.32 | *** join/#wowroster sepeck (n=sepeck@054.172-78-65.ftth.swbr.surewest.net) |
21:13.58 | *** join/#wowroster iafhq (n=iafhq@24-216-66-15.dhcp.stls.mo.charter.com) |
21:15.03 | iafhq | hi, I dont have CharacterProfiler.lua or PvPLog.lua why is that? |
21:29.21 | *** join/#wowroster Sylphid (n=gamesand@64.6.6.6.outfitters.com) |
21:53.50 | Anaxent | have you downloaded them yet |
21:54.07 | Anaxent | they are seperate addons that ae installed into the wow addon directorys |
22:57.08 | iafhq | nope, not yet may I get a link? |
23:01.40 | *** join/#wowroster Sylphid|work (n=gamesand@staff-110.outfitters.com) |