| 00:23.42 | mpictor | brlcad: regarding https://github.com/stepcode/stepcode/issues/238 (STEPattribute copy constructor), should it be a shallow copy, or deep? |
| 00:23.57 | mpictor | If deep, the destructor will need changed |
| 00:26.02 | mpictor | huh. I forgot that I had configured konversation to substitute links for references to issues |
| 00:34.55 | mpictor | I'll try a shallow copy and see if it causes any obvious problems. |
| 01:08.52 | brlcad | mpictor: yeah, I'm not sure myself |
| 01:09.34 | brlcad | on the surface, I'd hope a shallow copy would work but that requires one of the two copies to know that it's the authoritative holder that needs to actually free it |
| 01:09.50 | brlcad | and I don't see how it can know that other than position in the hierarchy |
| 01:11.24 | brlcad | so it's really a question of whether 1) the existing reference counting works and 2) is set up to be counted correctly |
| 01:12.59 | mpictor | I'm not sure that there is any reference counting |
| 01:13.44 | mpictor | some of the objects - such as AttrDescriptors - are created when the schema is initialized |
| 01:14.27 | mpictor | I *think* they are all destroyed in a destructor, but I am not sure |
| 01:23.43 | mpictor | STEPattribute already has an incomplete copy constructor and a ShallowCopy function that I don't really understand |
| 01:23.48 | mpictor | https://github.com/stepcode/stepcode/blob/master/src/clstepcore/STEPattribute.cc#L644 |
| 01:24.38 | mpictor | looks like it checks whether *this* is a redefining attr, then copies from sa depending on the result |
| 08:53.36 | *** join/#stepcode kesha_ (~kesha@14.139.122.114) |
| 09:14.03 | *** join/#stepcode kesha_ (~kesha@14.139.122.114) |
| 12:05.30 | *** join/#stepcode mpictor_ (~mpictor_@2600:1015:b105:5d1b:0:46:f33f:d701) |
| 12:28.20 | *** join/#stepcode kesha_ (~kesha@14.139.122.114) |
| 12:38.28 | kesha_ | Hi mpictor_ |
| 12:39.16 | kesha_ | Have a look at these commits https://github.com/stepcode/stepcode/commits/ks/headers |
| 12:55.36 | mpictor_ | Hi kesha_ |
| 12:55.47 | mpictor_ | I just commented on this on github |
| 12:56.52 | mpictor_ | That installs the headers from include/express and include/exppp but not the ones in include/ and not the generated ones |
| 12:57.50 | mpictor_ | I think the generated ones can be treated like any other header - by the time they are needed, they will exist |
| 12:58.58 | mpictor_ | There is a cmake variable that names the build dir; I don't remember its name off the top of my head. It will be in the cmake documentation |
| 13:05.09 | kesha_ | I didn't do for generated coz I was confused a bit- the generated ones are to be included from main CMakelist.txt or from the CMakeLists.txt in include/ |
| 13:05.11 | kesha_ | ? |
| 13:22.53 | *** join/#stepcode mpictor_ (~mpictor_@2600:1015:b105:5d1b:0:46:f33f:d701) |
| 13:24.47 | starseeker | mpictor_: any ideas on how to handle initialization of aggregates in multiple inheritance situations? |
| 13:26.24 | kesha_ | mpictor_: are you talking abt these ? http://www.cmake.org/cmake/help/v2.8.1/cmake.html#section_VariablesthatControltheBuild |
| 14:17.40 | kesha_ | 1. changed path where headers of exppp and express were included .../stepcode/... |
| 14:18.22 | kesha_ | 2. exppp and express were not using ${INCLUDE_INSTALL_DIR}. Done that |
| 14:18.46 | kesha_ | 3. generated headers from build/include/* included |
| 14:19.10 | kesha_ | 4. other headers from stepcode/include/*.h also included |
| 14:19.24 | kesha_ | Anything else needs to be done mpictor_ ? |
| 14:23.49 | mpictor_ | I think that's it. I won't be able to look at it immediately, though. |
| 14:25.40 | kesha_ | its fine. look at your convinience :) |
| 15:16.44 | *** join/#stepcode mpictor_ (~mpictor_@2600:1015:b105:5d1b:0:46:f33f:d701) |
| 16:07.16 | *** join/#stepcode kesha_ (~kesha@14.139.122.114) |
| 16:47.19 | *** join/#stepcode kesha_ (~kesha@14.139.122.114) |
| 19:04.30 | *** join/#stepcode kesha_ (~kesha@14.139.122.114) |
| 20:17.30 | *** join/#stepcode mpictor (~mark@2601:d:b280:b5:d63d:7eff:fe2d:2505) |
| 21:41.56 | mpictor | kesha_: if you haven't seen the notification, I fixed the problem with your pull request so I could merge it |
| 22:08.27 | *** join/#stepcode travis-ci (~travis-ci@ec2-54-226-159-156.compute-1.amazonaws.com) |
| 22:08.27 | travis-ci | [travis-ci] stepcode/stepcode#27 (master - 8e236bf : Mark): The build is still failing. |
| 22:08.27 | travis-ci | [travis-ci] Change view : https://github.com/stepcode/stepcode/compare/352fd6d66ed6...8e236bfda726 |
| 22:08.27 | travis-ci | [travis-ci] Build details : http://travis-ci.org/stepcode/stepcode/builds/10217518 |
| 22:08.27 | *** part/#stepcode travis-ci (~travis-ci@ec2-54-226-159-156.compute-1.amazonaws.com) |
| 22:29.38 | *** join/#stepcode travis-ci (~travis-ci@ec2-54-226-159-156.compute-1.amazonaws.com) |
| 22:29.38 | travis-ci | [travis-ci] stepcode/stepcode#29 (master - a60e03d : Mark): The build is still failing. |
| 22:29.38 | travis-ci | [travis-ci] Change view : https://github.com/stepcode/stepcode/compare/8e236bfda726...a60e03dd7ab4 |
| 22:29.38 | travis-ci | [travis-ci] Build details : http://travis-ci.org/stepcode/stepcode/builds/10218772 |
| 22:29.38 | *** part/#stepcode travis-ci (~travis-ci@ec2-54-226-159-156.compute-1.amazonaws.com) |
| 22:29.47 | *** join/#stepcode travis-ci (~travis-ci@107.20.109.156) |
| 22:29.47 | travis-ci | [travis-ci] stepcode/stepcode#30 (master - da3fe45 : Mark): The build is still failing. |
| 22:29.47 | travis-ci | [travis-ci] Change view : https://github.com/stepcode/stepcode/compare/a60e03dd7ab4...da3fe4543f86 |
| 22:29.47 | travis-ci | [travis-ci] Build details : http://travis-ci.org/stepcode/stepcode/builds/10218789 |
| 22:29.47 | *** part/#stepcode travis-ci (~travis-ci@107.20.109.156) |