| 08:45.12 | *** join/#stepcode kesha_ (~kesha@49.202.231.232) |
| 10:11.38 | *** join/#stepcode mpictor (~mark@2601:d:b280:9:d63d:7eff:fe2d:2505) |
| 11:03.51 | *** join/#stepcode kesha__ (~kesha@49.202.231.232) |
| 12:26.31 | *** join/#stepcode kesha__ (~kesha@49.202.231.232) |
| 12:52.14 | kesha__ | Hi mpictor |
| 12:52.46 | mpictor | hi kesha_ |
| 12:53.10 | mpictor | how are you today? |
| 12:54.16 | kesha__ | good. from last 2-3 days I am alright, recovered almost completely. :) |
| 12:54.45 | kesha__ | then I helped sean with making release notes. |
| 12:55.50 | kesha__ | How are you ? |
| 12:56.00 | mpictor | wow it must have really knocked you out |
| 12:56.20 | mpictor | lots of coffee in me, so I'm good for now :D |
| 12:57.32 | kesha__ | <PROTECTED> |
| 12:59.50 | mpictor | what about https://github.com/stepcode/stepcode/issues/21 ? |
| 13:00.15 | mpictor | I'd re-run cppcheck, since the code has changed a lot since then |
| 13:00.57 | mpictor | the reported issues should be pretty straightforward |
| 13:01.16 | mpictor | unlike moving the files around and merging the code |
| 13:10.58 | kesha__ | I am running cppcheck. i will get back to you if i am stuck somewhere. |
| 13:15.13 | mpictor | cool |
| 13:15.13 | kesha__ | its taking a long time |
| 13:15.44 | kesha__ | just checked 5/250 files -1% so far ! |
| 13:19.25 | mpictor | yea it will take a while |
| 13:22.31 | kesha__ | oops ! It was checking the build directory too.I opened the file cppcheck-issues.txt to see the output and all were from build directory. |
| 13:22.35 | kesha__ | I am re-running it excluding build/. |
| 14:17.12 | kesha__ | Shall I remove the unused variables or comment them with msg unused? |
| 14:17.53 | kesha__ | Some of the cppcheck output claims variable to be unused, but it is actaully used. |
| 15:17.44 | mpictor | for unused variables in C, just remove them. if in doubt, add a comment about removing them |
| 15:18.49 | mpictor | in c++, check whether there are virtual members involved |
| 15:21.29 | mpictor | if you have class A{ virtual foo(x) {/*use x*/};} and class B{ foo(x){/*don't use x*/};} and you change B::foo(x) to B::foo(), you won't get an error |
| 15:22.34 | mpictor | but calling foo(x) on an object of type B will use A::foo(x) instead of B::foo() |
| 15:22.39 | mpictor | which will result in bugs |
| 15:23.06 | mpictor | I'm sure you can guess how I learned that ;) |
| 16:09.40 | *** join/#stepcode kesha (~kesha@49.248.244.77) |
| 16:14.53 | *** join/#stepcode kesha_ (~kesha@49.248.244.77) |
| 16:34.17 | kesha_ | hehe..yes ;) |
| 17:46.44 | *** join/#stepcode kesha__ (~kesha@49.202.239.138) |
| 17:58.15 | *** join/#stepcode kesha__ (~kesha@49.202.239.138) |
| 18:18.26 | *** join/#stepcode kesha__ (~kesha@49.202.239.138) |