| 00:00.00 | blast007 | it* |
| 00:04.31 | short_circuit | Is this 'master' branch? |
| 00:05.03 | short_circuit | n/m |
| 00:06.18 | blast007 | 2.4 |
| 00:08.54 | short_circuit | just update after clean. gonna make just out of curiousity. |
| 00:10.44 | allejo | BZFlag 2.4.20 "Do You See What I See?" |
| 00:10.53 | macsforme | now it seems to honor vsync if there's just another window blocking it, but it still runs unthrottled when switching it to a different space, for example |
| 00:15.16 | macsforme | so I guess it's less likely to be encountered, but maybe worth leaving the workaround in anyway |
| 00:20.22 | macsforme | I probably shouldn't have hard-coded 65 FPS, though |
| 00:31.48 | blast007 | short_circuit is getting two warnings in src/bzfs/RecordReplay.cxx, lines 2068 and 2069, about "specified bound 32 equals destination size [-Wstringop-truncation]" (and 128 for the second line) |
| 00:31.55 | blast007 | how do we fix that? |
| 00:33.11 | short_circuit | squee |
| 00:33.22 | blast007 | for some reason it didn't do it here for me - rebuilding to make sure it wasn't a wonky old build |
| 00:33.52 | blast007 | short_circuit: was that with --enable-debug passed to configure? |
| 00:34.16 | blast007 | (I'm assuming not since you ran the game afterwards, but it could have been an old binary) |
| 00:35.41 | short_circuit | no enable debugging |
| 00:36.01 | short_circuit | sry. had to... refresh myself XD |
| 00:37.35 | BZNotify | 022.4 @ bzflag: 03macsforme pushed 1 commit (06https://git.io/JfLFs): |
| 00:37.36 | BZNotify | 022.4 @ bzflag: 03macsforme 148bca92: Removed the workaround for SDL bug #3146 which has been fixed (unclear when), where toggling fullscreen would mess up the windowed resolution. (06https://git.io/JfLFG) |
| 00:38.17 | short_circuit | I haven't done debug in quite a while. I'm at your service for a while. Guys and gals. Debian 10 up to date but i assume that's not so important. |
| 00:39.47 | blast007 | doing a non-debug build here as it worked fine in debug |
| 00:39.56 | BZNotify | bzflag: 03macsforme edited issue #246 "Aggregated issues related to SDL 2 window creation" (06https://git.io/JvMNY) |
| 00:43.54 | blast007 | hmm, yeah, I do see those warnings now when I build in non-debug |
| 00:44.54 | short_circuit | Sounds odd to this neophyte. |
| 00:47.40 | macsforme | anyone else think the whole main menu could be shifted down a bit now that one or two options were moved elsewhere? |
| 00:47.59 | blast007 | I'm scared of touching this file because last time I did, I broke replays :) |
| 00:48.47 | short_circuit | 8) |
| 00:50.03 | blast007 | I almost want to remove the resizable attribute from Linux windows as it's so very broken.. |
| 00:55.03 | blast007 | macsforme: including the title image at the top? |
| 00:56.26 | blast007 | changing line 173 to this seems to work okay in a quick test: float y = (float)_height - titleFontSize * 1.75f; |
| 00:57.32 | short_circuit | quick test build :) |
| 00:57.58 | short_circuit | n/m... :) |
| 00:58.01 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLFA): |
| 00:58.02 | BZNotify | 022.4 @ bzflag: 03blast007 14121f3d: Update the ChangeLog (06https://git.io/JfLFx) |
| 00:58.10 | short_circuit | now quick test build XD |
| 00:58.46 | BZNotify | 022.4 @ bzflag-dependencies: 03blast007 pushed 2 commits (06https://git.io/JfLFj): |
| 00:58.47 | BZNotify | 022.4 @ bzflag-dependencies: 03blast007 141681d8: Update dependencies: (06https://git.io/JfLbe) |
| 00:58.48 | BZNotify | 022.4 @ bzflag-dependencies: 03blast007 148888b4: According to the PDCurses wincon/README.md, the UTF8 option alone does nothing without the WIDE option, so add the WIDE option. (06https://git.io/JfLbv) |
| 00:59.06 | short_circuit | quick test build, no clean, no warnings |
| 00:59.56 | short_circuit | should I try a make clean then start over? |
| 01:01.28 | blast007 | short_circuit: no, the warning you have is real |
| 01:02.00 | blast007 | but since non-debug builds don't treat warnings as errors, it just lets it build successfully |
| 01:02.35 | short_circuit | Oki doki. Then no more colored letters in the scrolling foreign language ;) |
| 01:05.46 | blast007 | :) |
| 01:10.36 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLbZ): |
| 01:10.37 | BZNotify | 022.4 @ bzflag: 03blast007 14dc196b: Remove a couple files from the Xcode project that no longer exist. (06https://git.io/JfLbn) |
| 01:16.38 | macsforme | blast007: https://imgur.com/a/QjdGZ15 ? |
| 01:18.09 | blast007 | ah, so just the menu items |
| 01:20.32 | blast007 | kinda looks weird with the gap |
| 01:22.17 | macsforme | the title and instructions were spaced out a bit more too |
| 01:24.41 | macsforme | not a big deal either way... I just thought it looked odd the current way |
| 01:27.34 | BZNotify | bzflag: 03allejo 03opened pull request #250 "Bump banner to 2.4.20" (06https://git.io/JfLbH) |
| 01:28.07 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLbQ): |
| 01:28.08 | BZNotify | 022.4 @ bzflag: 03blast007 1437d97d: Space the main menu items out a bit more (06https://git.io/JfLb7) |
| 01:28.45 | blast007 | allejo: hehe, I actually had Photoshop today so I had a modified title here :) |
| 01:28.52 | allejo | oh nice :D |
| 01:29.07 | allejo | works for me! |
| 01:32.59 | blast007 | is it just Arial font, right? |
| 01:35.38 | allejo | Arial Black |
| 01:37.37 | Zehra | Quick question with regards to permissions.... If the "poll" permission is not granted, but the "poll kick" permission is, what should occur? |
| 01:37.50 | Zehra | Or poll permission is denied. |
| 01:38.09 | allejo | i think poll is required |
| 01:39.33 | Zehra | Ah okay, was wondering if that was expected as it seemed partially counter-intuitive. |
| 01:40.53 | allejo | nope. for whatever reason, that's very granular compared to other stuff |
| 01:43.21 | blast007 | just checked my photoshop - and it is using Arial Black. I was concerned because I knew I only saw the word "Arial" on that line, but the "Black" is in the second dropdown. :) |
| 01:47.27 | allejo | ah it shows up as its own font for me *shrug* |
| 01:47.38 | allejo | as long as it's black and not bold, it works |
| 01:48.03 | blast007 | maybe it's a newer Photoshop version? this is also on Windows, if that matters. |
| 01:54.50 | *** join/#bzflag short_circuit (~spldart@2601:2c5:c680:87a0:36e8:94ff:fed6:c206) |
| 01:58.27 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLNn): |
| 01:58.28 | BZNotify | 022.4 @ bzflag: 03blast007 14da385d: Show the language name for Czech and Português. (06https://git.io/JfLNc) |
| 02:04.13 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLNz): |
| 02:04.14 | BZNotify | 022.4 @ bzflag: 03blast007 141964d1: Fix a few loss of precision warnings from Visual C++. (06https://git.io/JfLNg) |
| 02:06.54 | blast007 | Anyone know what should be done to fix that GCC8 warning in RecordReplay.cxx? otherwise I'm just gonna wrap it in some #pragma to ignore it for now |
| 02:10.39 | macsforme | is it an issue with the two being the same size and it thinks there needs to be room for the terminating null byte? |
| 02:11.43 | macsforme | so maybe the combination of strncpy() and sizeof() is not the right |
| 02:12.06 | blast007 | yeah, that is the problem |
| 02:12.11 | macsforme | maybe strlen() instead? |
| 02:12.19 | blast007 | hmm |
| 02:13.48 | blast007 | well, that compiled without warnings now |
| 02:15.52 | macsforme | I wonder if that doesn't copy the terminating null, though |
| 02:20.01 | blast007 | what about this afterwards? hdr.callSign[sizeof(hdr.callSign)-1] = '\0'; |
| 02:20.05 | blast007 | (and the same for motto) |
| 02:20.29 | macsforme | yeah, to be safe |
| 02:20.50 | blast007 | I'm gonna test this quick :) |
| 02:22.28 | macsforme | it looks like others are fixing it via sizeof(source) - 1 |
| 02:22.31 | *** mode/#bzflag [-v short_circuit] by ChanServ |
| 02:26.00 | blast007 | I'm just real scared to do much in this file cuz I broke it last time ;) |
| 02:48.23 | blast007 | okay, yeah, that does not work |
| 02:49.54 | blast007 | (I just get a blank author instead of the callsign) |
| 02:52.24 | blast007 | with 'sizeof(...) - 1' it works, though |
| 02:55.00 | *** join/#bzflag short_circuit (~spldart@2601:2c5:c680:87a0:3210:b3ff:fef0:93af) |
| 03:14.15 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLAh): |
| 03:14.16 | BZNotify | 022.4 @ bzflag: 03blast007 1493b3f7: rrlog needs to link to libcurl because of TextUtils's URL functions (06https://git.io/JfLAj) |
| 03:30.35 | Zehra | Perhaps some insights into https://github.com/BZFlag-Dev/bzflag/issues/248 - Rewrite BZDB to be a smarter structure #248 |
| 03:30.59 | macsforme | if we pass sizeof(source) - 1 as the size parameter to strncpy, it sounds like the terminating null byte does not get copied if the string is the maximum length |
| 03:32.47 | Zehra | What if the line of thinking is reversed to an extent with regards to the implementation. |
| 03:33.24 | Zehra | Rather than seeing if it is, instead if it is "logically" possible. |
| 03:33.31 | blast007 | macsforme: dunno.. it is working when I max out the callsign and motto length |
| 03:33.45 | blast007 | (at least, with what the client's UI allows for) |
| 03:34.35 | macsforme | the last byte might be null by chance, unless it's being cleared manually beforehand |
| 03:35.16 | macsforme | might still be worth it to manually zero them out, or at least the last byte of each |
| 03:37.16 | blast007 | okay, I'll try with zeroing out the last byte |
| 03:46.11 | blast007 | hmm, does this zero out everything? memset(&hdr, 0, sizeof(hdr)); |
| 03:48.16 | blast007 | Zehra: what? |
| 03:52.18 | Zehra | blast007: From what it seems, most of the issues regarding BZDB seem related to the way the data is sorted and searched... |
| 03:53.00 | Zehra | So what if the data is searched by a type of probability, moving on to lesser ones, minimizing the amount of calculations needed. |
| 03:53.05 | blast007 | sorted? |
| 03:53.56 | blast007 | the problem is that BZDB is slow because it's parsing strings repeatedly |
| 03:55.12 | Zehra | That's why it could be sorted out differently, for instance, let's use "_drawClouds" or any of the boolean variables... |
| 03:55.23 | Zehra | Even if I put in "random" it will still be searched... |
| 03:55.34 | blast007 | wut |
| 03:55.59 | Zehra | Try in any server variable and add in non-sensical input. |
| 03:56.22 | CaptainRoberts[m | Double whut? |
| 03:57.04 | Zehra | Most of the time, it will be "set" to it, despite not doing anything or even being "valid" as a variable. |
| 03:57.50 | Zehra | So what if we use the variables to determine if something should be "searched", moving on from most likely to least likely. |
| 03:58.07 | blast007 | I have absolutely no idea what you are talking about |
| 03:58.26 | blast007 | I'm gonna go back to working on releating 2.4.20 now |
| 03:59.08 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLpf): |
| 03:59.09 | BZNotify | 022.4 @ bzflag: 03blast007 1482fd45: Fix a GCC8 warning (specified bound X equals destination size [-Wstringop-truncation]) (06https://git.io/JfLpJ) |
| 04:03.00 | The_Noah | when someone steals a flag to me the first callsign should not be repeated in the actual message, so it would be - blast: stole The Noah's flag - instead of - blast: blast stole The Noah's flag - https://imagebin.ca/v/5KIeLaIvX4ho |
| 04:09.38 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLpW): |
| 04:09.39 | BZNotify | 022.4 @ bzflag: 03blast007 14138183: Remove duplicated callsign from the flag stolen message. (06https://git.io/JfLpl) |
| 04:09.54 | The_Noah | yay :D |
| 04:10.26 | blast007 | looking into one last thing and then I'll be testing builds and then pushing the version bump |
| 04:10.32 | The_Noah | sweet |
| 04:10.58 | The_Noah | is there a plan on moving to VS2019? |
| 04:11.50 | blast007 | going with the release name that allejo mentioned "Do You See What I See?" |
| 04:11.59 | blast007 | for this release? nope |
| 04:12.13 | The_Noah | No not for this release, but sometime in the "near" future. |
| 04:12.18 | blast007 | I only have 2017 at the moment and I try to avoid having multiple versions installed at once |
| 04:12.37 | blast007 | for master, probably |
| 04:13.07 | blast007 | does 2019 still work on Windows 7? ;) |
| 04:13.31 | The_Noah | idk, I haven't used Window 7 in years :D |
| 04:13.58 | blast007 | still has it on his dev workstation |
| 04:14.21 | blast007 | I had 8.1 and now 10 on my gaming machine |
| 04:15.00 | The_Noah | I only used Windows 8 once, it was on my sister's laptop and it was very interesting. |
| 04:15.04 | blast007 | I don't really use the Windows 7 system for anything except development now |
| 04:15.19 | blast007 | my main systems are all Debian |
| 04:15.27 | allejo | wooo my release name was picked :D |
| 04:15.42 | The_Noah | :) |
| 04:18.57 | the_map | that's the name you choose, after 2.4.12 "Silence is Golden"? :p |
| 04:19.20 | the_map | wait nvm it's 2.4.18 that's relevant |
| 04:19.49 | allejo | :p |
| 04:19.56 | blast007 | allejo: okay, the reason some options get reset (such as blending) when going from 2.4.19 to an older version is because there didn't use to be defaults for those options |
| 04:20.10 | blast007 | it use to be set during the performance test |
| 04:20.24 | blast007 | because there are defaults now, the value isn't stored if it matches the default |
| 04:20.33 | blast007 | think I should change that, or is it fine? |
| 04:21.30 | blast007 | to be fair, downgrading the config file isn't a "supported" thing so I'm inclined to just leave it as is |
| 04:21.46 | allejo | do we forsee players needing to downgrade from 2.4.20? |
| 04:21.57 | allejo | right, we don't need to support going backwards |
| 04:22.51 | blast007 | I feel it's a minor issue |
| 04:22.51 | allejo | was just bothersome whenever i was testing a dev build but we're not breaking backward-compat so i think it's fine to leave as is |
| 04:23.05 | blast007 | k |
| 04:34.24 | BZNotify | 022.4 @ bzflag: 03blast007 pushed 1 commit (06https://git.io/JfLpX): |
| 04:34.25 | BZNotify | 022.4 @ bzflag: 03blast007 142567e5: Bump version to 2.4.20. (06https://git.io/JfLp1) |
| 04:42.28 | BZNotify | bzflag: 03allejo 04closed pull request #250 "Bump banner to 2.4.20" (06https://git.io/JfLbH) |
| 04:55.03 | BZNotify | bzflag: 03blast007 03tagged * 2567e505 (Bump version to 2.4.20.) as 02v2.4.20 (06https://git.io/JfLpp) |
| 04:55.41 | blast007 | working on the site update and forum post |
| 04:55.57 | allejo | yayyyy |
| 04:55.59 | allejo | claps |
| 04:56.03 | allejo | cheers |
| 04:56.27 | The_Noah | keep pushing refresh on the website |
| 05:00.15 | blast007 | The_Noah: you'll see the commit get pushed here first ;) |
| 05:00.30 | The_Noah | Ah sweet. |
| 05:00.33 | blast007 | (and then the update cron job has to run) |
| 05:01.32 | The_Noah | :D |
| 05:10.58 | blast007 | my internet went down right as I was pushing the commit :P |
| 05:11.50 | The_Noah | :p |
| 05:12.23 | BZNotify | 02master @ bzflag.org: 03blast007 pushed 1 commit (06https://git.io/JfLhq): |
| 05:12.24 | BZNotify | 02master @ bzflag.org: 03blast007 14ee778b: Add the 2.4.20 release. (06https://git.io/JfLhm) |
| 05:17.45 | The_Noah | Done installing :D |
| 05:21.41 | The_Noah | quick question what is remote sounds? |
| 05:23.44 | The_Noah | Also the MOTD needs to be updated :) |
| 05:24.50 | blast007 | oh yeah |
| 05:27.12 | blast007 | looks like Remote Sounds controls if you hear the burrow, jump, wings flap, or bounce sounds of remote players |
| 05:27.59 | blast007 | or the 'land' sound |
| 05:30.53 | The_Noah | huh, interesting. |
| 06:02.44 | blast007 | will deal with the flatpak tomorrow... |
| 06:06.17 | BZNotify | 02master @ bzflag.org: 03blast007 pushed 2 commits (06https://git.io/JfLhi): |
| 06:06.18 | BZNotify | 02master @ bzflag.org: 03blast007 14bab46c: Clarify the release description. (06https://git.io/JfLhP) |
| 06:06.19 | BZNotify | 02master @ bzflag.org: 03blast007 1435a508: Update the MOTD. (06https://git.io/JfLhX) |
| 07:28.22 | *** join/#bzflag Sgeo (~Sgeo@ool-18b982ad.dyn.optonline.net) |
| 08:33.00 | tupone | I see in github the tar but "Latest release" is still 2.4.18. Is the 2.4.20 ready to be deployed ? |