| 02:14.13 | *** join/#bzflag infobot (ibot@208.53.50.136) |
| 02:14.13 | *** topic/#bzflag is https://BZFlag.org || http://ohloh.net/p/bzflag || https://bzflag.org/help || Channel Logs: http://infobot.rikers.org/%23bzflag/ || 2.4.18 released! https://forums.bzflag.org/viewtopic.php?f=62&t=20030 |
| 02:14.13 | *** mode/#bzflag [+v infobot] by ChanServ |
| 02:51.03 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |
| 03:14.34 | *** join/#bzflag DTRemenak (~DTRemenak@2605:e000:141f:c002:ace3:b854:f729:37fc) |
| 03:14.34 | *** join/#bzflag DTRemenak (~DTRemenak@about/essy/CrazyCoder/DTRemenak) |
| 03:14.34 | *** mode/#bzflag [+v DTRemenak] by ChanServ |
| 03:15.13 | BulletCatcher | The overflow warning reported by tupone is clearly correct even if we can't reproduce it. For example, 2147483647 (INT_MAX) is 11 characters long and would overflow the 10-character buffer. |
| 03:15.14 | BulletCatcher | I suggest making the buffer 21 characters long so a 64-bit int will fit, and also using snprintf() to ensure that those 128-bit ints of the 23rd century won't cause an actual overflow. |
| 03:17.25 | blast007 | Yeah, not saying it isn't correct. I was just hoping I can have an environment where those warnings show up. |
| 03:21.08 | BulletCatcher | When we are ready to commit to C++11 we can use std::to_string() to eliminate many such potential buffer overflows. |
| 03:49.19 | BulletCatcher | With gcc-7.3.1 -Wformat-overflow=2 (note the numeral) results in a total of 16 warnings in 2.4.19 including the one in multicast.cxx . |
| 04:06.17 | blast007 | that helps, thanks |
| 04:06.30 | blast007 | I wasn't doing the =2 part |
| 04:46.02 | *** join/#bzflag korolev (~korolev@c-73-179-85-246.hsd1.fl.comcast.net) |
| 14:54.54 | *** join/#bzflag joevano (~joevano@bzflag/developer/JoeVano) |
| 14:54.54 | *** mode/#bzflag [+v joevano] by ChanServ |
| 18:07.36 | *** join/#bzflag BZnotify (BZnotify@gateway/service/github.com/x-lylotsccykraddtj) |
| 18:07.36 | BZnotify | [13bzflag.org] 15allejo pushed 1 new commit to 06redesign: 02https://git.io/fpewn |
| 18:07.36 | BZnotify | 13bzflag.org/06redesign 14552021c 15Vladimir Jimenez: Display API fxns in alphabetical order correctly |
| 18:07.36 | *** part/#bzflag BZnotify (BZnotify@gateway/service/github.com/x-lylotsccykraddtj) |
| 19:41.35 | tupone | Actually that int is the ip port so 16 bits should be enough that gives 5 digits ... But who knows what can happens. Maybe port should be an uint16_t instead of an int |
| 19:57.58 | blast007 | yeah, there's some data type changes that could occur, but I'll just correct the buffer size for now |