| 02:01.55 | *** join/#bzflag ruskie (~ruskie@sourcemage/mage/ruskie) |
| 13:04.37 | *** join/#bzflag nadir (uid134094@gateway/web/irccloud.com/x-ishgfqdxbkqmrbxm) |
| 18:07.23 | blast007 | When switching from a playable tank to an observer, should the active shots for that player immediately end? |
| 18:08.52 | blast007 | we also have this "shots" variable in the Player class that doesn't seem to be used. Should it be? https://github.com/BZFlag-Dev/bzflag/blob/2.4/src/bzflag/Player.h#L225 |
| 18:09.12 | allejo | would you want to be killed by an observer? |
| 18:10.13 | blast007 | LocalPlayer has it's own LocalShotPath** shots; ( https://github.com/BZFlag-Dev/bzflag/blob/2.4/src/bzflag/LocalPlayer.h#L131 ) and RemotePlayer has RemoteShotPath** shots ( https://github.com/BZFlag-Dev/bzflag/blob/2.4/src/bzflag/RemotePlayer.h#L45 ) |
| 18:30.42 | blast007 | allejo: I'd think not :) |
| 18:45.26 | JeffM | was probalby from the attempt to unify shots |
| 18:47.21 | blast007 | should that still be done? currently I'm adding a duplicate method to both LocalPlayer and RemotePlayer to loop through and expire all the shots |
| 18:47.41 | blast007 | s/duplicate/identical/ |
| 18:47.44 | JeffM | depends how far you want to go with it |
| 18:47.58 | JeffM | if the derived classes have the same thing, move it into the base |
| 18:48.12 | JeffM | the full plan for shots was to give them all a unique ID so they can exist with out a player |
| 18:48.46 | JeffM | localplayer was the only person who'd keep local shots, for client side prediction, untill they came back with real IDs from the server |
| 18:52.23 | blast007 | I suppose I'll just do what I'm doing for now then. It's just a 5 line function for each class. |
| 18:54.04 | blast007 | When the client receives the MsgSetTeam that sets a player to observer, it immediately expires all the shots for that tank (either for myTank, or whatever remotePlayer). |
| 18:55.50 | blast007 | Other thing I'm not quite sure how to fix is the death arc after switching from playable team to observer and back quickly. Hackish fix would just be preventing the switch back to a playable team until _explodeTime seconds have passed. ;) |
| 18:56.31 | blast007 | (the problem is that the tank will still be in the death arc motion when switching back to a playable team if it was still within the _explodeTime) |
| 19:15.29 | JeffM | the death arc code should check the current team, and if it 's observer cancel the death stuff |
| 19:25.45 | *** join/#bzflag dngor (abuse@p3m/dngor) |
| 21:02.56 | *** join/#bzflag bertman (~bert@unaffiliated/bertman) |
| 21:36.08 | *** join/#bzflag bertman (~bert@unaffiliated/bertman) |