| 00:04.38 | *** join/#bzflag Zehra (~Zehra@unaffiliated/zehra) |
| 00:12.52 | macsforme | https://github.com/BZFlag-Dev/bzflag/blob/2.4/DEVINFO#L60-L62 |
| 00:14.33 | macsforme | when a submission has not only spelling, grammar, or formatting problems, but has had no apparent testing (and is targeted for merging into the stable branch), the value of the submission is greatly reduced |
| 00:15.43 | macsforme | BulletCatcher just spent a great deal of effort to correct a bunch of incorrect whitespace and formatting |
| 00:18.42 | macsforme | so I feel it is not unreasonable to ask contributors to clean up their own submissions... or, if another developer finds it worthwhile to help clean it up and test it, they can lend a hand |
| 00:22.34 | macsforme | the issues allejo pointed out are valid, specific, and easy to correct |
| 00:39.01 | BulletCatcher | We already specify the indenting style at the bottom of most files and in the .editorconfig file. |
| 00:39.03 | BulletCatcher | If there is anything else that will help developer tools automatically conform to our style then lets do that too. |
| 00:39.40 | JeffM | Yeah,reject it |
| 00:41.28 | allejo | if this checked (https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/#enabling-repository-maintainer-permissions-on-existing-pull-requests) then I'll take it over and clean up the formatting unless no one wants the feature |
| 00:44.18 | JeffM | It's checked |
| 00:47.38 | allejo | cool |
| 00:52.43 | JeffM | I completely agree with the policy, I just don't care enough about that item to do anything |
| 00:53.19 | blast007 | fwiw, there is a grand total of 1 server that is running with handicap |
| 00:53.46 | blast007 | and I don't think the reason why it's just 1 is because there's no API hooks |
| 00:56.28 | *** join/#bzflag AAA_awright (~aaa@2607:5300:60:7d4::1) |
| 00:58.09 | JeffM | Oh probably |
| 00:58.33 | JeffM | It's a hack to get around non-per tank settings |
| 00:58.34 | allejo | is that one server me? because if it is, it was probably a typo or copy paste error :p |
| 00:58.45 | JeffM | I'd only expect it to be used by special plugins |
| 00:59.35 | allejo | do we want the feature? my only experience with handicap enabled was people complaining about cheats |
| 00:59.55 | JeffM | gives 0 ducks |
| 01:00.25 | blast007 | no, it's some 2.4.4 server that says 2.4.2 in the -publictitle and 2.0.16 in the -srvmsg |
| 01:00.59 | allejo | woohoo! not me |
| 01:07.40 | the_map | either that or you need to update your servers :P |
| 01:08.53 | allejo | i typically use the latest 2.4 branch. so that's why if it breaks it's probably my fault for not testing |
| 03:48.58 | JeffM | will bzflag support my joystick that has 13 axes and 49 buttons? |
| 03:53.00 | JeffM | tho I guess it's actualy 2 joysticks |
| 04:09.06 | allejo | if there's a PR with correct indentation, then maybe :p |
| 04:11.43 | JeffM | I installed the thing |
| 04:16.28 | allejo | :D |
| 04:20.43 | macsforme | does anyone actually play bz with a joystick? |
| 04:20.55 | The_Hand_of_Mike | pete does |
| 04:21.11 | The_Hand_of_Mike | he plays with a kind of pedal set that is made off an older Thurstmaster |
| 04:21.21 | The_Hand_of_Mike | Thrustmaster, pardon |
| 04:22.50 | macsforme | game controller support would probably make more sense (which you can do with joystick stuff currently, but I think there's a separate SDL game controller API) |
| 04:29.06 | macsforme | there's some kind of really weird dead zone around the center, and the diagonal maximum extent is like 0.7 |
| 04:33.37 | macsforme | (with the current joystick handling code) |
| 04:34.35 | JeffM | On Windows it's XInput for stuff like xbox controllers |
| 04:38.20 | macsforme | I guess the stuff I was referring to is in SDL specifically |
| 04:38.37 | macsforme | or in our SDL platform code, rather |
| 04:39.17 | JeffM | Sometimes you need to calibrate them to get them to register right |
| 07:04.25 | *** join/#bzflag dngor (abuse@p3m/dngor) |
| 07:16.37 | macsforme | I meant it goes in a circle, so your maximum magnitude is 1, and your maximum x,y position at 45 degrees is 0.7, 0.7, so you can't turn as fast as mouse or keyboard players can |
| 11:09.52 | blast007 | that sounds like a bug that should be fixed, then |
| 11:31.20 | blast007 | I'd have to add some value output to the screen to be sure, but it doesn't *feel* like I have that issue on Windows with my Saitek P2500 analog gamepad |
| 12:04.07 | *** join/#bzflag L4m3r_ (~l4m3r@bzflag/developer/L4m3r) |
| 12:04.07 | *** mode/#bzflag [+v L4m3r_] by ChanServ |
| 12:15.28 | blast007 | macsforme: does macOS have some native control panel for game controllers that shows the joystick axis positions? |
| 12:28.43 | *** join/#bzflag BZnotify (~BZnotify@192.30.252.42) |
| 12:28.43 | BZnotify | [13bzflag.org] 15blast007 pushed 1 new commit to 06master: 02https://git.io/vDyBA |
| 12:28.43 | BZnotify | 13bzflag.org/06master 14b86d4a7 15Scott Wichser: Add a bit more to the Getting Started document. |
| 12:28.43 | *** part/#bzflag BZnotify (~BZnotify@192.30.252.42) |
| 12:49.02 | *** join/#bzflag nadir (uid134094@gateway/web/irccloud.com/x-jffztdwwqdblopdd) |
| 13:22.09 | blast007 | it could possibly even be a limitation of whatever gamepad/joystick device you're using |
| 14:04.27 | blast007 | I will have to compare with a Linux build to see how the same controller behaves there, as on Windows we use DirectInput directly, not SDL2's input layer |
| 14:18.16 | macsforme | not a control panel per se... I think I made bz output some stuff to verify what I was seeing, and I might have used an SDL testing tool also |
| 14:19.15 | blast007 | https://github.com/BZFlag-Dev/bzflag.org/blob/master/_documentation/getting_started.md Are there any other topics that should be covered in the Getting Started document? Trying to keep it to the minimum info needed for a new player to get into the game without feeling lost. I'll probably link to some other documentation pages for things like server commands. |
| 14:19.49 | blast007 | I should probably include info about leading your shots |
| 16:21.48 | JeffM | macsforme: you could add a polar mode that compensated for that |
| 16:27.51 | JeffM | and did you use the actual gamecontroller class or the joystick stuff, looks like they added https://wiki.libsdl.org/CategoryGameController |
| 16:31.19 | blast007 | heh, for a sec I thought we already had Windows XInput support, then I realized the X11 Input extension is also called XInput :P |
| 16:31.32 | JeffM | naw that won't be confusing :) |
| 16:32.53 | JeffM | I guess the odd thing about bzflag is that it puts rotation and translation on the same stick by default |
| 16:33.03 | JeffM | normal xbox style twin stick games don't |
| 16:33.20 | JeffM | one stick is forward/backwards/left/right and another is all rotations |
| 16:34.10 | JeffM | so for translations you WANT The circular nature of the stick, since it gives you a vector lenght of 1 all the time (you can't move faster by going 100% sideways and 100% forwards) |
| 16:34.43 | JeffM | I'd think for bzflag you'd want to split turn and drive onto different sticks for a similar mapping, it would just not allow sidestep or look up/down |
| 16:35.22 | blast007 | we are using the SDL_Joystick* functions |
| 16:35.34 | JeffM | yeah old stuff |
| 16:35.51 | JeffM | the gameconroller API makes it easy to do logical mappins |
| 16:35.52 | blast007 | we already do have turn and drive split |
| 16:36.01 | blast007 | you pick which axis you want for each |
| 16:36.10 | JeffM | sure, but what is default for any new controler? |
| 16:36.19 | JeffM | IIRC it puts them on one stick |
| 16:36.20 | blast007 | X and Y |
| 16:36.30 | JeffM | yeah those are axes on a single stick in the device |
| 16:36.41 | JeffM | not bzflag's fault, but I could see how if someone didn't change it, it would be odd |
| 16:36.43 | blast007 | so? |
| 16:37.04 | blast007 | that makes the most sense with a gamepad so you've got one hand to hit the buttons |
| 16:37.06 | JeffM | thats why he gets .707 as a max value when at a 45 |
| 16:37.19 | JeffM | what kind of gamepad are you thinking about? |
| 16:37.34 | JeffM | on an xbox one you'd want to use the triggers |
| 16:37.35 | blast007 | dual analog gamepad, similar to the PS2 |
| 16:37.51 | JeffM | sure same thing, use the triggers, should not use the buttons for much at all |
| 16:37.57 | JeffM | triggers and bumpers |
| 16:38.03 | JeffM | all the thumbs! :) |
| 16:38.04 | blast007 | there's only gonna be four buttons then |
| 16:38.32 | JeffM | that's the max you get with out a thumb lift anyway |
| 16:39.42 | blast007 | jump, shoot, lock/spawn, radar zoom, drop flag |
| 16:40.05 | JeffM | I'd move radar zoom to the dpad, |
| 16:40.38 | JeffM | right trigger shoot, left trigger jump, right bumper lock/spawn, left bumper drop flag |
| 16:40.46 | JeffM | dpad up/down for radar zoom |
| 16:41.10 | JeffM | left stick for movement, right stick for turning |
| 16:41.35 | JeffM | that'd be what I think default was |
| 16:41.52 | JeffM | if you do want movement and rotaiton on the same stick you'll need some polar correction code |
| 16:42.40 | JeffM | it makes sense to make that an option, but a default may want to work similar to other FPS games |
| 16:42.57 | blast007 | you'd probably need polar correction code anyway |
| 16:43.06 | JeffM | yeah it's not bad stuff to have |
| 16:44.00 | blast007 | still thinking it might just be a crap joystick/gamepad that has a circular limiter and doesn't account for it in their chip |
| 16:44.18 | JeffM | no, I just checked it out with a 360 controller |
| 16:44.24 | blast007 | oh? |
| 16:44.33 | JeffM | they are intdended to provide a vector, not 2 axis values |
| 16:44.49 | JeffM | the vector will have a max lenght of 1 |
| 16:45.03 | JeffM | the magnitude is your speed, the direction is the direction |
| 16:45.04 | blast007 | I will have to check with actual numbers instead of my "feeling" :) |
| 16:45.31 | JeffM | it assumes both axes are of the same "type" |
| 16:45.36 | JeffM | linear or rotary, not a mix |
| 16:45.37 | JeffM | http://html5gamepad.com/ |
| 16:47.14 | JeffM | https://usercontent.irccloud-cdn.com/file/cpRpEIVo/you%20can%20see%20the%20axis%200%20and%20axis%201%20are%20not%20a%20full%20values%2C%20that's%20with%20the%20left%20stick%20shoved%20into%20a%20corner |
| 16:48.29 | blast007 | my Saitek has a more square shaped limiter, and in Windows's joystick properties screen it was moving all the way to the corners of the square there |
| 16:48.41 | JeffM | yeah some do |
| 16:48.59 | blast007 | but that display may be correcting to polar coordiates for all I know :) |
| 16:48.59 | JeffM | my saitek stick totaly moves like that for the main axes |
| 16:49.15 | blast007 | I've got an Xbox One controller I can try as well |
| 16:49.42 | JeffM | the little thumb sticks on the X56 behave the same as the xbox analog stick |
| 16:49.47 | JeffM | they can't go full 45 |
| 16:50.05 | blast007 | is there a way to automatically detect that? |
| 16:50.14 | JeffM | dunno |
| 16:50.26 | blast007 | can't say I've ever seen a game that game me an option for that |
| 16:50.56 | JeffM | well like I say, they probalby often put the same unity types on linked axes |
| 16:51.24 | JeffM | I wonder what elite does, it has a LITTANY of control options |
| 16:51.44 | JeffM | though the thumbsticks do controll units of the same type on both axes, thrusters |
| 20:11.39 | *** join/#bzflag Zehra (~Zehra@unaffiliated/zehra) |