| 00:14.28 | *** join/#bzflag Delusional (~delusiona@unaffiliated/delusional) |
| 00:20.32 | *** join/#bzflag apeman (~Victor@222-155-154-108.jetstream.xtra.co.nz) |
| 03:16.02 | *** join/#bzflag apeman1 (~Victor@222-155-154-108.jetstream.xtra.co.nz) |
| 03:18.19 | *** join/#bzflag Pimpinella (~frank@gondolin.pimpi.org) |
| 03:25.52 | allejo | joevano come back. you can blame it all on brad! |
| 05:19.30 | *** join/#bzflag tw1sted_ (~tw1sted@192.241.163.210) |
| 05:25.24 | *** join/#bzflag JBdiGriz (~dbw@108-197-33-160.lightspeed.sndgca.sbcglobal.net) |
| 06:40.49 | *** join/#bzflag noyb (~noyb@cpe-172-250-108-23.socal.res.rr.com) |
| 07:00.49 | *** join/#bzflag tw1sted (~tw1sted@unaffiliated/tw1sted) |
| 07:32.10 | allejo | I would push to the wrong repo -_- |
| 07:36.33 | allejo | permission denied? :x |
| 07:40.51 | BulletCatcher | Only blast007 and JeffM can grant access to the import-3 repo. |
| 07:41.13 | BulletCatcher | You'll have to wait until tomorrow, I guess. |
| 07:44.17 | BulletCatcher | Just need to add the new repo to the developers team. |
| 07:45.50 | allejo | ah alrighty, fine by me |
| 07:46.01 | allejo | thanks BulletCatcher :) |
| 07:46.55 | BulletCatcher | :-) |
| 07:47.53 | BulletCatcher | Near the end of your changes, please use strncpy() to prevent overflowing the char arrays in startupInfo. |
| 07:49.50 | BulletCatcher | Also, use the ServerPort constant in Protocol.h instead of hardcoding 5154. |
| 07:50.08 | allejo | oh buffer overflow with strcpy()... |
| 07:51.07 | apeman1 | mm buffet overflow |
| 07:51.40 | BulletCatcher | The old code was *very* careful not to overflow. |
| 07:57.58 | allejo | With strncpy() it requires I add a null terminator while strcpy() doesn't. If I truncate values before the strcpy(), that wouldn't cause a bufferoverflow, right? |
| 07:59.26 | BulletCatcher | Correct. |
| 07:59.27 | BulletCatcher | It should be sufficient, although a bit more fragile, to truncate the std::string variables if they are oversize. |
| 08:00.49 | BulletCatcher | Don't forget to warn the player about any truncations. |
| 08:04.23 | allejo | Of course |
| 08:12.35 | apeman1 | what do you look for when "identifier not found" but you did include the header for that public function? |
| 08:15.52 | allejo | BulletCatcher, mind checking my commit now? |
| 08:16.18 | apeman1 | nevermind its the same name but differnt number of arguments |
| 08:20.40 | BulletCatcher | In the length checks you need to use >= instead of > to allow for the terminating null. |
| 08:25.36 | allejo | does that mean i'm deleting one less than I should with the .erase()? |
| 08:26.52 | BulletCatcher | I haven't looked at erase() to see exactly how it works. |
| 08:27.39 | BulletCatcher | I recommend testing to be sure it works correctly. |
| 08:31.03 | allejo | after truncating, I have 31 characters being passed to startupInfo. that's correct, right? |
| 08:34.03 | BulletCatcher | CallSignLen and PasswordLen are both 32 in global.h, so 31 leaves room for the terminating null. |
| 08:37.13 | allejo | hmmm how would I test for an overflow? pass more than 32 characters? |
| 08:37.21 | BulletCatcher | yup |
| 08:39.11 | allejo | would I be expecting a crash or a memory leak? |
| 08:40.31 | BulletCatcher | Probably just corruption of other parts of startupInfo. |
| 08:42.44 | allejo | No corruption here :D |
| 08:42.53 | BulletCatcher | yay |
| 08:43.37 | allejo | thanks for the help :) |
| 08:43.52 | BulletCatcher | Thanks for rewriting it! |
| 08:44.55 | *** join/#bzflag dngor (abuse@p3m/dngor) |
| 08:45.39 | BulletCatcher | The more we can use std::string variables instead of character arrays, the less likely it will be that we have overflow problems. |
| 08:49.34 | allejo | hurray for less overflow! |
| 08:49.48 | BulletCatcher | We may be able to completely eliminate char[] for the password and server name, but the call sign needs to have a maximum length for transmission via the network protocol. |
| 08:53.18 | apeman1 | How hard is it to remove all uses of BzfMedia? |
| 08:54.15 | apeman1 | as in will the jenga tower inevitably collapse if i try to |
| 08:55.09 | BulletCatcher | It looks like BZfMedia is mosty for sound. |
| 08:55.59 | BulletCatcher | Try replacing BzfMedia.h and BzfMedia.cxx with empty files and see how it goes. |
| 08:56.22 | apeman1 | is it needed for downloading worlds? |
| 08:57.36 | BulletCatcher | Not that I can see. |
| 08:58.16 | BulletCatcher | But it may be used for the default texture images. |
| 08:58.27 | apeman1 | its needed for fonts |
| 08:58.51 | apeman1 | well, unless there is another way to get the result of PlatformFactory::getMedia()->getMediaDirectory() |
| 08:59.41 | BulletCatcher | There's always another way. |
| 08:59.43 | BulletCatcher | It just depends on what you're trying to accomplish. |
| 09:07.40 | *** join/#bzflag sam_ (~sam@poulet.zoy.org) |
| 09:07.41 | *** join/#bzflag McYukon_ (~McYukon@192.65.241.17) |
| 09:09.31 | apeman1 | what is MsgFetchResources to do with? |
| 09:10.38 | *** join/#bzflag Cobra_Fast_ (~coprah@wtwrp.de) |
| 09:15.55 | *** join/#bzflag Delusional (~delusiona@unaffiliated/delusional) |
| 09:17.52 | *** join/#bzflag khonkhortisan (~kyle@c-50-132-81-139.hsd1.wa.comcast.net) |
| 10:43.15 | Notify | 03BZFlag:Allejo * 8742 /Bz_getPlayerTeam: Oh my god was the example fugly |
| 10:58.24 | *** join/#bzflag meeba (~lamer@c-75-71-23-204.hsd1.co.comcast.net) |
| 12:38.17 | *** join/#bzflag meeba_ (~lamer@c-75-71-23-204.hsd1.co.comcast.net) |
| 16:32.21 | *** join/#bzflag TimRiker (~TimRiker@bzflag/projectlead/TimRiker) |
| 16:32.21 | *** mode/#bzflag [+o TimRiker] by ChanServ |
| 16:45.19 | *** join/#bzflag contempt (contempt@unaffiliated/contempt) |
| 16:54.18 | *** join/#bzflag contempt (contempt@unaffiliated/contempt) |
| 17:00.13 | *** join/#bzflag contempt (contempt@unaffiliated/contempt) |
| 17:04.11 | *** join/#bzflag JeffM (~JeffM@unaffiliated/jeffm2501) |
| 17:04.11 | *** mode/#bzflag [+v JeffM] by ChanServ |
| 17:11.42 | *** join/#bzflag contempt (contempt@unaffiliated/contempt) |
| 17:28.37 | BulletCatcher | JeffM, if you'll add the new bzflag-import-3 repo to the list at https://github.com/organizations/BZFlag-Dev/teams/441158 then allejo and others will be able to push to it. |
| 17:29.12 | JeffM | ok, let me see if I remember how to do that |
| 17:29.23 | BulletCatcher | I don't seem to have access to do that myself. |
| 17:30.49 | JeffM | should be good now |
| 17:31.10 | BulletCatcher | I see it. Thanks. |
| 17:31.12 | JeffM | I had to add the repository to the "team" |
| 17:31.54 | BulletCatcher | In my view I see no buttons for making changes. |
| 17:31.58 | JeffM | do any more people need to be added to the team |
| 17:32.24 | BulletCatcher | Not that I know of at this time, except for maybe TimRiker. |
| 17:36.28 | blast007 | BulletCatcher: yeah, perhaps... the new year *is* coming up soon... ;) |
| 17:36.38 | BulletCatcher | :-p |
| 17:37.14 | BulletCatcher | Who owns the Notifico account at http://n.tkte.ch/BZFlag/ ? |
| 17:37.28 | BulletCatcher | I'd like to get the import-3 repo added to it. |
| 17:37.32 | JeffM | have you automated the copyright thingy yet |
| 17:38.04 | JeffM | done |
| 17:38.12 | BulletCatcher | I'm not sure what you mean. |
| 17:38.24 | JeffM | updating the copyright date |
| 17:38.33 | JeffM | the thing that happens every new year |
| 17:38.56 | JeffM | oops. I just added all my personal projects to notifico |
| 17:38.57 | JeffM | fixing |
| 17:39.26 | JeffM | do you want import 2 to be in the list still? |
| 17:39.29 | BulletCatcher | We still have the misc/touchcopyright script, but it is a bit early to be changing it to 2014. |
| 17:39.37 | BulletCatcher | Yes, for now. |
| 17:39.58 | JeffM | if Target can put out christmas stuff before haloween, we can talk about changing the date :) |
| 17:40.15 | BulletCatcher | Talk, yes. Act, not yet. :-) |
| 17:40.30 | JeffM | ok, the settings should be good now |
| 17:40.36 | JeffM | you won't see when I do my homework |
| 17:40.50 | BulletCatcher | That's probably for the best. :-) |
| 17:40.54 | JeffM | indeed |
| 17:41.14 | JeffM | I just clicked the "Sync with Github" button and didn't think what would do |
| 17:41.25 | JeffM | IIRC blast has the login for the site as well |
| 17:41.38 | BulletCatcher | Apparently it defaults to the #commits channel, so they should be changed to #bzflag. |
| 17:43.17 | JeffM | try a test commit now |
| 17:43.50 | BulletCatcher | Also, a URL needs to be pasted into the WebHook at https://github.com/BZFlag-Dev/bzflag-import-3/settings/hooks |
| 17:45.53 | JeffM | stand-by, getting dizzy |
| 17:46.54 | JeffM | I redid the sync, and told it to automaticly add the hooks |
| 17:47.18 | BulletCatcher | It's there now. |
| 17:47.35 | BulletCatcher | Gotta think of something to commit. |
| 17:47.48 | blast007 | whitespace fix! |
| 17:55.34 | BulletCatcher | taps his foot |
| 17:55.52 | *** join/#bzflag Not-002 (~notifico@198.199.82.216) |
| 17:55.53 | Not-002 | [02bzflag-import-3] 07JMakey pushed 031 commit to 03v2_4_x [+1/-1/±0] 13http://git.io/Za05Ag |
| 17:55.54 | Not-002 | [02bzflag-import-3] 07JMakey 035a64b6e - Make .h file non-executable. Maybe it will stay that way this time. |
| 17:56.05 | BulletCatcher | yay |
| 17:59.40 | BulletCatcher | The bzworkbench and bzflag-art repos both still point to #commits at n.tkte.ch . |
| 18:00.51 | JeffM | fixed |
| 18:01.57 | BulletCatcher | missing # |
| 18:02.47 | JeffM | sorry |
| 18:02.52 | JeffM | I'm on drugs right now |
| 18:03.30 | JeffM | the dayquil isn't being my friend |
| 18:03.56 | BulletCatcher | Looks good now. Thanks. |
| 18:04.00 | JeffM | sure |
| 18:04.05 | BulletCatcher | Don't do drugs, kids! |
| 18:04.16 | JeffM | yeah and don't get sick, it sucks |
| 18:04.29 | JeffM | even if you do sound like batman |
| 18:04.34 | BulletCatcher | lol |
| 18:04.50 | BulletCatcher | I know what you mean! |
| 18:07.39 | JeffM | at least I can read my programing book from 1978 |
| 18:07.59 | BulletCatcher | allejo, don't forget to pull from import-3 before you rebase your command line parsing rewrite onto it. |
| 18:08.00 | BulletCatcher | That way there won't be a pointless branch that then has to be merged. |
| 18:08.12 | blast007 | depending on the level of congestion, you may even sound like Bat Vader http://static.bzexcess.com/bat_vader.jpg |
| 18:08.39 | BulletCatcher | "Bruce, I am your father!" |
| 18:08.50 | JeffM | well then at least batman would have a dad |
| 18:08.59 | JeffM | then he'd not have to be batman anymore |
| 18:12.51 | blast007 | http://static.bzexcess.com/batman_mask.jpg :P |
| 18:14.38 | BulletCatcher | I think that's everything we need to do to make the bzflag-import-3 repo fully functional. |
| 18:15.51 | BulletCatcher | I want to do some further changes, but maybe the next import can be the final one. |
| 18:32.36 | JeffM | whooo... lookit all them branches |
| 18:33.27 | JeffM | once you do the final import we can take the tarbals and bins from sf and attatch them to the releases on github |
| 18:33.45 | JeffM | in case SF ever decides to attatch mallware to them |
| 18:43.26 | blast007 | I also have just a bit of excess bandwidth on my server |
| 18:43.43 | blast007 | using less than 450GB/month of my 5TB |
| 18:44.08 | blast007 | and most of that is from the daily backups |
| 18:46.43 | *** join/#bzflag brlcad (~sean@66-118-151-70.static.sagonet.net) |
| 18:51.33 | JeffM | sure if we need more mirrors, but I dont think we use that much for downloads and keeping the bins with the source is a good idea |
| 18:51.56 | JeffM | how many new user registrations do we get a month? |
| 18:52.03 | JeffM | that actualy activate |
| 18:53.59 | *** join/#bzflag ts (~ts@66-118-151-70.static.sagonet.net) |
| 19:03.04 | BulletCatcher | Some of that bandwidth might get used if you bring back Missile War 2, blast007. |
| 19:03.38 | blast007 | BulletCatcher: MW2.3 is still running.. doesn't get played |
| 19:03.53 | BulletCatcher | hrmf |
| 19:04.53 | blast007 | recently, Rat's Nest did better than MW2.3 |
| 19:06.07 | blast007 | but there's some annoying map glitches with Rat's Nest that I'd want fixed before I ran it again (like preventing team flags from being placed on the inaccessible roof) |
| 19:24.27 | *** join/#bzflag cods (~cods@tuxee.net) |
| 19:59.17 | *** join/#bzflag Tuxist (~quassel@p4FEEDADD.dip0.t-ipconnect.de) |
| 20:01.41 | JeffM | well there are only so many maps 25-45 people will play |
| 20:23.05 | *** join/#bzflag apeman (~Victor@222-155-154-108.jetstream.xtra.co.nz) |
| 20:37.39 | blast007 | apeman: are you going forward with your "headless client" idea? |
| 20:55.03 | apeman | blast007: yes, i have been trying. But like you suspect of course its a hack job not a "refactoring of 10000 lines" |
| 20:55.37 | blast007 | s/hack job/dead end job/ |
| 20:56.58 | apeman | i dont need to account for the possibility of bzflag 2.6 |
| 20:57.49 | apeman | if you mean its not practically possible, i try impossible things all the time, at "worst" i'll learn my lesson |
| 20:58.18 | blast007 | I mean, don't expect us to accept that code, if that's your goal |
| 20:58.34 | apeman | of course thats not my goal :P |
| 20:59.36 | apeman | i ask on this channel because there are the most users, not because its to do with the official repo |
| 21:05.38 | *** join/#bzflag Guest833 (4506744c@gateway/web/freenode/ip.69.6.116.76) |
| 21:10.34 | apeman | it worked, i removed all the GUI from the client but it can still play. However it still has low FPS and high CPU consumption |
| 21:11.30 | *** join/#bzflag JeffM (~Jeffery@cpe-23-241-222-73.socal.res.rr.com) |
| 21:11.30 | *** join/#bzflag JeffM (~Jeffery@unaffiliated/jeffm2501) |
| 21:11.30 | *** mode/#bzflag [+v JeffM] by ChanServ |
| 21:14.02 | apeman | is it windows dynamic priority scheduling that causes client to have low framerate when minimized/out of focus, or something to do with opengl? |
| 21:14.19 | JeffM | both |
| 21:14.56 | JeffM | apps that arn't in focus can have there GL context reset a lot |
| 21:15.01 | JeffM | they also get less cycles of CPU |
| 21:17.45 | JeffM | are you trying to do split screen multiplayer or something? |
| 21:17.59 | blast007 | he's making a headless client |
| 21:18.07 | JeffM | why? |
| 21:18.34 | apeman | to run autopilot in the background |
| 21:18.38 | JeffM | and isn't that what bzrobots is? |
| 21:18.57 | blast007 | pretty much |
| 21:19.08 | apeman | except bzrobots isnt usable atm |
| 21:19.16 | JeffM | so fix it :) |
| 21:19.18 | blast007 | apeman: you sure? |
| 21:19.40 | apeman | whats bzrobots again? :D |
| 21:19.57 | blast007 | it was used for AI projects |
| 21:20.01 | JeffM | a headless client for bots |
| 21:20.27 | apeman | was it the one used by a professor for a course |
| 21:20.52 | JeffM | and was an SOC project |
| 21:21.39 | apeman | despite being used in the course, i believe the one in the code base is highly incomplete |
| 21:21.43 | blast007 | http://svn.code.sf.net/p/bzflag/code/branches/experimental/v2_99continuing/bzflag/src/bzrobots/ |
| 21:21.49 | JeffM | possibly |
| 21:21.58 | JeffM | but it'll be closer to what you need then the graphical client |
| 21:22.04 | JeffM | but whatever floats your boat |
| 21:22.17 | JeffM | clients will run slower in the background |
| 21:22.22 | JeffM | but it won't be a big deal for you |
| 21:22.26 | JeffM | since most time is spent drawing |
| 21:22.36 | JeffM | since you won't be drawing you will have plenty of cycles to do what you need to do |
| 21:22.46 | apeman | the python binding stuff also confuses me |
| 21:23.39 | apeman | i already removed all the Windows and displays and stuff, i believe only the gl____ plotting commands are left |
| 21:23.46 | JeffM | fun |
| 21:23.57 | JeffM | I'd have made a new platform class called "headless" or something |
| 21:24.05 | JeffM | then just install that instead of the sdl or windows |
| 21:25.03 | apeman | haha yes that might have worked |
| 21:25.24 | JeffM | would not take care of the GL stuff, but it'd be a cleaner way of taking care of the rest of the stuff |
| 21:26.10 | apeman | you can remove the window just by changing a WinAPI showWindow(true) to showWindow(false) |
| 21:26.23 | JeffM | on windows |
| 21:26.44 | JeffM | but that still means you are getting window messages |
| 21:26.48 | apeman | but it consumes more CPU than it does when the screen is drawn. |
| 21:26.50 | JeffM | so that'll be interesting |
| 21:27.00 | JeffM | yeah it's probably spinning forevers |
| 21:27.21 | apeman | now removing the Win windows and opengl context it is still about the same |
| 21:27.22 | JeffM | I'd have made a headless client be a command line app on windows not a windows app |
| 21:27.36 | JeffM | you have to get rid of the message pump |
| 21:27.48 | JeffM | you don't want no windows messages |
| 21:27.49 | apeman | message pump? |
| 21:27.57 | JeffM | you want it to run more like SDL does with a closed loop |
| 21:27.58 | JeffM | yup |
| 21:28.10 | JeffM | you can't just sit in a while loop in windows and draw stuff |
| 21:28.18 | JeffM | you need to check for window messages |
| 21:28.24 | JeffM | normaly windows is event based |
| 21:28.39 | JeffM | if you want to be frame based you have to "pump" messages into the message sysetem |
| 21:28.48 | JeffM | since you want to draw when there is no user input |
| 21:29.21 | JeffM | all exe's that are built as "windows" applications assume there will be a message system and at least one "win proc" |
| 21:29.29 | JeffM | thats why they have winmain instead of main |
| 21:30.57 | apeman | how do i convert it to a console app in MSVC? |
| 21:31.23 | JeffM | it's a property in the proeject settings |
| 21:31.33 | JeffM | but then you have to change the platform a lot |
| 21:31.39 | JeffM | since none of the winproc stuff will work |
| 21:31.48 | JeffM | bzfs.exe is set as command line |
| 21:31.52 | JeffM | the client is not |
| 21:32.49 | JeffM | personaly I'd copy the SDL platform to a headless one, and remove the SDL calls |
| 21:33.04 | JeffM | then for headless mode have all the platform stuff return headless platform classes that don't do anything |
| 21:33.15 | JeffM | and then send the headless code into the sdl style main and loops |
| 21:33.25 | JeffM | that will make it run much more like the server |
| 21:33.42 | JeffM | console applications run better in the background too |
| 21:36.32 | apeman | If you install SDL on windows will the defines automatically trigger SDL platform instead of win platform? |
| 21:38.05 | JeffM | oh god no |
| 21:38.24 | JeffM | the platform that is used is a compile time thing not a run time thing |
| 21:40.05 | apeman | yes but will it compile to use SDL without changing anything once i'd installed it |
| 21:40.16 | JeffM | no |
| 21:40.28 | JeffM | the windows projects are hardcoded to use the windows platform |
| 21:40.39 | JeffM | it's the configure step on linux that makes it switch platforms |
| 21:40.46 | JeffM | windows has no configure step |
| 21:46.38 | apeman | what was the exact showstopper for 3.0? Things were started and left unfinished? Too many bugs? Too many unmerged branches? Not enough features? |
| 21:46.50 | JeffM | yes |
| 21:47.04 | JeffM | no desire |
| 21:47.05 | JeffM | mostly |
| 21:47.14 | JeffM | few people understand the changes that were made |
| 21:47.38 | JeffM | at this point it'd be hard to move the changes in 2.4 into the 2.99 codebase |
| 21:47.49 | JeffM | simpler to backport what we wanted into 2.6 |
| 21:48.47 | apeman | what would be so bad if 3.0a2 or whatever version was released? |
| 21:48.57 | JeffM | it crashes a lot |
| 21:49.13 | JeffM | it lacks some of the features in 2.4 |
| 21:49.44 | JeffM | so it'd confuse the 25-45 players that are left |
| 21:55.21 | apeman | it works as a commandline program, but CPU consumption and FPS seem about the same |
| 21:55.53 | apeman | unless Debug version has something to do with it |
| 21:56.22 | apeman | whats the proper way to let it sleep? |
| 21:56.25 | JeffM | well yeah it's going to try to run as fast as possible |
| 21:56.28 | JeffM | call sleep |
| 21:56.46 | JeffM | and it's still calling all the drawing code |
| 21:56.59 | apeman | TimeKeeper or Win's sleep |
| 21:57.21 | JeffM | timekeeper should map to the correct thing for the OS so it's generaly better to use |
| 21:57.28 | JeffM | then it'd work on linux and OSX |
| 21:57.40 | apeman | so you'd expect calls like glPoint to take about the same time? |
| 21:57.52 | apeman | even if there isnt a gl context? |
| 21:58.03 | JeffM | yeah it still shuffles data around |
| 21:58.06 | JeffM | that's the big wait |
| 21:58.20 | JeffM | throwing several thousand flaots around |
| 21:58.41 | JeffM | and all the function calls |
| 21:58.54 | JeffM | since they take time to run, detect an error, and return |
| 21:59.03 | JeffM | normalyh they'd pass the info the video card and return |
| 22:00.51 | apeman | is it safe to just delete every function call of glew.h? |
| 22:01.04 | JeffM | you need more then glew.h |
| 22:01.12 | JeffM | anything that calls gl.h |
| 22:01.17 | JeffM | or glu.h |
| 22:01.36 | JeffM | glew just does some special effects like anisotropic filtering |
| 22:02.00 | JeffM | I think all our GL calls go thu bzgl.h or something like that |
| 22:02.05 | JeffM | since apple put GL in a wierd place |
| 22:35.14 | apeman | :S i dont know why debug version can send a player to server but release version doesnt |
| 22:36.13 | JeffM | probalby an uninitalized variable |
| 22:36.19 | JeffM | the debuger inits all memory to 0 |
| 22:36.22 | JeffM | release does not |
| 22:36.29 | JeffM | 0 is probalby an ok value |
| 22:36.33 | JeffM | garbage is not |
| 22:36.51 | apeman | how can i debug release ? |
| 22:37.00 | JeffM | it's a pain |
| 22:37.07 | JeffM | turn on debuging symbols |
| 22:37.14 | JeffM | in the project properties |
| 22:37.23 | JeffM | then rebuild |
| 22:37.43 | JeffM | and then watch your breakpoints get skipped becauyse the optimizer removed or changed that code :) |
| 22:39.25 | apeman | haha well for starters i didnt have the command arguments set for Release |
| 22:43.18 | Not-002 | [02bzflag-import-3] 07allejo pushed 031 commit to 03v2_4_x [+0/-0/±1] 13http://git.io/nPCbSQ |
| 22:43.19 | Not-002 | [02bzflag-import-3] 07allejo 0393325d7 - Rewrote the command line parsing and have sanity checks |
| 22:45.02 | allejo | why is whitespace so atrocious throughout the source? tabs and spaces every where :( |
| 22:47.44 | JeffM | different editors, different people |
| 22:47.55 | JeffM | not everyone follows the rules at the bottom of each file |
| 22:48.02 | apeman | oh man that explains why i always thought the indenting style goes in and out for no reason |
| 22:48.35 | JeffM | it's an old codebase, it's been used by many different text editors |
| 22:50.35 | allejo | so according to the rules, it's using tabs of width 8? |
| 22:52.04 | JeffM | is that what it says in the block at the end of each file? |
| 22:52.52 | allejo | shrugs |
| 22:53.09 | allejo | it says tab-width 8 and indent-tabs-mode: t |
| 22:53.10 | JeffM | there is an emacs formating block at the end of each file |
| 22:53.18 | JeffM | that's what the "stadnard" is suposed to be |
| 22:53.29 | JeffM | not all edits are made with those settings |
| 22:55.49 | allejo | ew tabs :( |
| 22:56.23 | JeffM | modern editors should support tabs fine and they make edits easier |
| 22:56.35 | JeffM | hates having to hit delete 8 times |
| 22:57.19 | allejo | modern editors should delete 8 spaces if that's the size of a "tab" in spaces :P |
| 22:57.48 | JeffM | except when it gets screwed up because somehow there is only 7 of them :) |
| 22:57.51 | JeffM | it's too fragile a system |
| 22:58.01 | JeffM | it also makes the files larger and that bugs me |
| 22:58.22 | JeffM | but then I also don't like the standard that is setup for bzflag ether |
| 22:58.28 | JeffM | I find it all too hard to read |
| 23:04.59 | allejo | boooo :P |
| 23:05.05 | allejo | spaces > tabs ;) |
| 23:05.28 | JeffM | I bet you like to put the { on the same line as the if too |
| 23:05.29 | allejo | but yea, 8 spaces does seem a tad bit long for indents |
| 23:05.52 | allejo | no, i put the { on the next line so I can easily find where the closing one is |
| 23:06.06 | JeffM | then there is hope for you yet |
| 23:06.15 | allejo | lol |
| 23:06.32 | allejo | the only reason i put the { on the same line in my commit is because that's how the rest of the code is |
| 23:06.38 | JeffM | yeah |
| 23:06.46 | allejo | though i did only use spaces instead of tabs :P |
| 23:06.54 | JeffM | I "try" to remember to do that |
| 23:07.32 | allejo | the { on the same line? |
| 23:07.36 | JeffM | yeah |
| 23:07.51 | JeffM | my editor defautls to tabs so I don't have to worry about that |
| 23:08.18 | allejo | i think git may have a solution to change tabs to spaces on commit and vice versa |
| 23:08.31 | allejo | but i don't think that'd work out well if tabs are different sizes |
| 23:08.59 | JeffM | at some point we should use some tools to reformat the code back to some standard, we do that every so often |
| 23:09.27 | JeffM | and when we do that someone (me) will sugest that we change the standard. |
| 23:09.34 | JeffM | then someone else will say take a vote |
| 23:10.08 | JeffM | and then EVERYONE WHO EVER THOUGHT ABOUT COMMITING will come out of the woodwork to comment on what the standard should be even if they haven't commited in decades |
| 23:10.35 | allejo | if there is a reformat done, can the tab standard be changed? |
| 23:10.36 | allejo | oh :x |
| 23:10.43 | JeffM | try to get people to comment on feature, crickets, talk about whitespace, BAM WWIII |
| 23:10.55 | JeffM | nope, I love me some tabs :) |
| 23:10.58 | allejo | vim vs emacs also |
| 23:11.04 | JeffM | but I'd change the spacing |
| 23:11.17 | allejo | grrrr tabs *waves fist angrily* |
| 23:11.22 | allejo | yay progress! |
| 23:11.31 | JeffM | use some more systems other then yours and you'll change your mind eventualy |
| 23:11.58 | JeffM | really it doesn't matter what one is used, it just has to be consistent |
| 23:12.19 | JeffM | I just think when you hit the TAB key, it should you know, insert a TAB |
| 23:12.29 | JeffM | like it does for every other key :) |
| 23:13.23 | allejo | but then spaces don't mix well with tabs D: |
| 23:13.45 | JeffM | hence why you get it all fixed up |
| 23:13.53 | JeffM | once you are consistent it's ok |
| 23:14.03 | JeffM | mixing and having ether as a standard has problems |
| 23:14.17 | allejo | I'll believe it when i see the code reformatted :p |
| 23:14.23 | JeffM | we've done it before |
| 23:14.29 | JeffM | there are scripts and tools that do it |
| 23:14.34 | JeffM | can even fix the { parts |
| 23:14.48 | allejo | http://stackoverflow.com/a/2318063/1239484 |
| 23:14.49 | apeman | theres a linux builtin that does it |
| 23:15.00 | JeffM | they usualy arn't perfect but they get you a lot closer to being consisent |
| 23:15.20 | allejo | i'll tolerate the tabs if the braces could be fixed :p |
| 23:15.42 | allejo | and the stackoverflow could be of use to have git automatically switch to tabs, from what I understand |
| 23:16.18 | JeffM | well we should let BulletCatcher finish his last import then we can look into it |
| 23:16.27 | JeffM | since any reformat would hit a lot of files |
| 23:16.35 | JeffM | so we should finish all the imports and splits first |
| 23:16.57 | allejo | sounds good to me |
| 23:32.08 | *** join/#bzflag Delusional (~delusiona@unaffiliated/delusional) |
| 23:53.23 | *** join/#bzflag Pimpinella (~frank@gondolin.pimpi.org) |
