| 00:21.04 | *** join/#brlcad witness__ (uid10044@gateway/web/irccloud.com/x-qbjahnpzggsilegp) |
| 00:29.25 | zero_level | ``Erik what is seen in a patch submitted by a gsoc applicant.. is it the functions implemented or a primitive understanding of src compilation and coding style ? |
| 00:30.36 | zero_level | and also what is the recommended size of a patch |
| 01:35.03 | Notify | 03BRL-CAD Wiki:Fabricio13 * 0 /wiki/User:Fabricio13: |
| 02:30.39 | brlcad | caen23_: if it tells you to run svn upgrade, that's a client issue -- your checkout was checked out with a prior version |
| 02:30.50 | brlcad | newer versions always have you upgrade |
| 02:37.03 | brlcad | zero_level: unfamiliar developers communicate via patches (change sets) |
| 02:37.37 | brlcad | so yes patches certainly need to functionally demonstrate a basic understanding of compilation and coding style |
| 02:41.38 | brlcad | and no size criteria, they need to tell a succinct story well |
| 02:42.52 | brlcad | ideally they do one change, one feature, at a time (per patch) |
| 03:00.04 | Notify | 03BRL-CAD:brlcad * 55320 brlcad/trunk/sh/cmp.sh: the ', ' was an auto-formatting error. plus, the 100mm lower bound is insufficient for our sample models (was set up for vehicles), lower down one more level to 10mm. |
| 06:46.32 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 07:44.40 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 07:54.12 | *** join/#brlcad kesha__ (~kesha@14.139.122.114) |
| 08:11.07 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 08:15.33 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 09:04.44 | *** join/#brlcad maths22_ (~gcimaths@66-118-151-70.static.sagonet.net) |
| 09:04.59 | *** join/#brlcad n_reed_ (~molto_cre@66-118-151-70.static.sagonet.net) |
| 09:12.48 | *** join/#brlcad yiyus_ (1242712427@je.je.je) |
| 10:14.00 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 11:17.27 | Notify | 03BRL-CAD Wiki:Dingyong0474 * 0 /wiki/User:Dingyong0474: |
| 11:19.52 | Notify | 03BRL-CAD Wiki:Fengcshou123 * 0 /wiki/User:Fengcshou123: |
| 11:21.24 | Notify | 03BRL-CAD:bob1961 * 55321 (brlcad/trunk/include/dm-Null.h brlcad/trunk/include/dm.h and 9 others): This fixes the lighting problem exhibited in Archer when displaying geometry in shaded mode with perspective. The main issue here is that the perspective matrix needs to be fed separately to openGl's projection matrix stack instead of feeding the modelview matrix stack a matrix that has both view and perspective |
| 11:21.26 | Notify | rolled into a single matrix. |
| 12:03.21 | Notify | 03BRL-CAD Wiki:Phoenix * 5246 /wiki/User:Phoenix/GSoc2013/Proposal: /* Calculating surface-surface intersection curves */ |
| 12:05.43 | *** join/#brlcad d_rossberg (~rossberg@66-118-151-70.static.sagonet.net) |
| 12:11.22 | Notify | 03BRL-CAD:phoenixyjll * 55322 (brlcad/trunk/include/brep.h brlcad/trunk/src/libbrep/CMakeLists.txt and 7 others): Use the openNURBS API ON_Surface::IntersectSurface() for SSI. Move the ON_SSX_EVENT part from other/openNURBS to libbrep, and extend its functionality. The original SSI function brlcad::surface_surface_intersection() is replaced. |
| 12:12.29 | Notify | 03BRL-CAD Wiki:Phoenix * 5247 /wiki/User:Phoenix/GSoc2013/Proposal: /* Things I have done this year */ |
| 12:29.11 | *** join/#brlcad phoenixyjll (8c71fd66@gateway/web/freenode/ip.140.113.253.102) |
| 12:53.39 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 13:21.20 | Notify | 03BRL-CAD:carlmoore * 55323 brlcad/trunk/src/liboptical/sh_prj.c: fix a warning message about type mismatch in format |
| 13:24.52 | *** join/#brlcad caen23 (~caen23@92.85.93.49) |
| 13:25.58 | Notify | 03BRL-CAD:phoenixyjll * 55324 brlcad/trunk/src/libged/edit_metaball.c: MS Visual Studio returns const char * in strrchr. |
| 13:32.19 | Notify | 03BRL-CAD:carlmoore * 55325 brlcad/trunk/src/liboptical/sh_text.c: fix type warnings |
| 13:39.08 | Notify | 03BRL-CAD:bob1961 * 55326 brlcad/trunk/src/tclscripts/lib/Ged.tcl: Expose the "ae" command in Archer. |
| 14:25.31 | *** join/#brlcad vladbogo (~vlad@188.25.239.64) |
| 14:56.16 | Notify | 03BRL-CAD:starseeker * 55327 brlcad/trunk/misc/CMakeLists.txt: Add a 'doxygen' target, as well as a 'dox' target |
| 15:07.04 | Notify | 03BRL-CAD:bob1961 * 55328 brlcad/trunk/src/libged/annotate.c: Mods to annotate command ---> Check gedp before using. Also fixed a core dump issue caused by freeing memory twice. |
| 15:09.00 | Notify | 03BRL-CAD:bob1961 * 55329 (brlcad/trunk/src/libtclcad/tclcad_obj.c brlcad/trunk/src/tclscripts/lib/Ged.tcl): Expose the annotate command in Archer. |
| 15:15.45 | *** join/#brlcad jasleen (~jasleen@202.164.53.122) |
| 15:27.02 | Notify | 03BRL-CAD:starseeker * 55330 (brlcad/trunk/include/brep.h brlcad/trunk/misc/Doxyfile.in brlcad/trunk/misc/doxygen_structure): Start setting up to add libbrep to the doxygen system |
| 15:28.10 | Notify | 03BRL-CAD:n_reed * 55331 brlcad/trunk/src/other/step/src/clstepcore/ExpDict.cc: should use delete[] to free new[] memory |
| 16:01.59 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 16:14.21 | Notify | 03BRL-CAD:carlmoore * 55332 brlcad/trunk/src/libdm/dm-tk.c: fix type warnings |
| 16:28.42 | Notify | 03BRL-CAD:carlmoore * 55333 brlcad/trunk/src/liboptical/sh_treetherm.c: fix type warning |
| 16:46.49 | *** join/#brlcad rays2pix (~deepak@14.139.226.34) |
| 16:47.26 | Notify | 03BRL-CAD:bob1961 * 55334 brlcad/trunk/src/tclscripts/lib/Ged.tcl: Expose the "x" command in Archer. |
| 16:59.46 | Notify | 03BRL-CAD:bob1961 * 55335 brlcad/trunk/src/tclscripts/lib/Ged.tcl: Expose the "orientation" command in Archer. Fixed a typo in Ged::keypoint. |
| 17:08.43 | Notify | 03BRL-CAD Wiki:KeshaSShah * 5248 /wiki/User:KeshaSShah/GSoC13/Priority2: |
| 17:14.27 | Notify | 03BRL-CAD Wiki:KeshaSShah * 5249 /wiki/User:KeshaSShah/GSoC13/Reports: /* May 4-5 */ |
| 17:15.19 | Notify | 03BRL-CAD Wiki:KeshaSShah * 5250 /wiki/User:KeshaSShah/GSoC13/Reports: /* May 1 */ |
| 17:15.42 | Notify | 03BRL-CAD:starseeker * 55336 brlcad/trunk/src/libbrep/CMakeLists.txt: Add a 'tools' file for holding useful routines, analgous to the opennurbs_brep_tools.cpp file. Start with the sub-surface extraction routine. |
| 17:49.10 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 18:04.33 | Notify | 03BRL-CAD:indianlarry * 55337 brlcad/trunk/src/librt/shoot.c: The non-uniform binary space partitioning tree used to partition solids into RPP cells within librt to speed raytracing was using an absolute "nudge" value to walk/step the ray into the next partition cell. In certain circumstances the "nudge" value was causing grazing cell hits to walk over thin intersections even when these intgersections were greater |
| 18:04.35 | Notify | than the thinness tolerance. This update modified this code to use our distance tolerance instead. Now our distance tolerance default or a user specified value can be used. This was turned up by Richard Weiss while testing 'rtarea' results from BREP conversions of our implicits. |
| 18:05.16 | Notify | 03BRL-CAD:indianlarry * 55338 brlcad/trunk/src/librt/primitives/brep/brep.cpp: Newton iterator wasn't converging to a solution for the EHY primitive converted to a BREP. The inverse jacobian was causing the iterator to jump to a solution that was farther away than the current point. Added a better half-step of the UV deltas until a closer solution is found. Will half-step up to 1000 iterations before bailing on the |
| 18:05.18 | Notify | shotline. Need to look at the surface to see why its causing such large steps but is a fix in the near term. This was turned up by Richard Weiss while testing 'rtarea' results from BREP conversions of our implicits. |
| 18:31.41 | Notify | 03BRL-CAD:starseeker * 55339 (brlcad/trunk/src/libbrep/libbrep_brep_tools.cpp brlcad/trunk/src/libbrep/libbrep_brep_tools.h): Tweak the logic deciding when and how to split. |
| 18:56.12 | Notify | 03BRL-CAD:starseeker * 55340 brlcad/trunk/src/libbrep/libbrep_brep_tools.h: Tweak comment |
| 18:59.10 | Notify | 03BRL-CAD:starseeker * 55341 brlcad/trunk/src/libbrep/libbrep_brep_tools.h: gah - contents of, not pointer to |
| 19:05.32 | *** join/#brlcad cstirk (~quassel@c-71-56-216-45.hsd1.co.comcast.net) |
| 19:05.59 | *** join/#brlcad Ch3ck (~Ch3ck@41.205.16.70) |
| 19:06.12 | Ch3ck | Hi |
| 19:09.07 | brlcad | hi Ch3ck |
| 19:09.26 | Ch3ck | Hi brlcad |
| 19:09.29 | Notify | 03BRL-CAD:brlcad * 55342 brlcad/trunk/src/librt/primitives/brep/brep.cpp: all magic numbers should be documented. mention that this errantcount limit check number isn't really important, but does need to be big enough to help converge to an answer. |
| 19:09.55 | Ch3ck | i just wanted to know when the selected gsoc participants will be notified |
| 19:10.43 | Notify | 03BRL-CAD:brlcad * 55343 brlcad/trunk/src/libged/edit_metaball.c: make last const instead of casting away const |
| 19:10.52 | brlcad | Ch3ck: it's on the melange timeline |
| 19:11.14 | brlcad | now's the time to be responding to comments and working on awesome patches |
| 19:11.20 | Ch3ck | ok thanks |
| 19:11.31 | brlcad | with as competitive as it's going to be this year, patches are going to be very important |
| 19:11.50 | Ch3ck | ok |
| 19:12.00 | Ch3ck | so how many participants are going to be selected? |
| 19:12.02 | brlcad | if you don't have one in, you should definitely work on one .. if you do, you might want to work on another more involved |
| 19:12.11 | brlcad | depends on how these reviews go |
| 19:13.20 | brlcad | any limitation on selections will be self-imposed |
| 19:13.46 | Ch3ck | ok |
| 19:14.01 | Ch3ck | so can i still work on my proposal even though the deadline is passed? |
| 19:14.15 | brlcad | sure |
| 19:14.22 | brlcad | that's part why we had people cross-post to the wiki |
| 19:14.35 | Ch3ck | because based on the corrections you gave me i tried to communicate with you online |
| 19:14.36 | brlcad | plus as we ask questions, edits are expected |
| 19:14.45 | Ch3ck | but you weren't there.. |
| 19:14.55 | brlcad | i'm always here |
| 19:14.58 | Ch3ck | ok |
| 19:15.04 | brlcad | but i'm not always available |
| 19:15.10 | Ch3ck | well let me give you the link to my proposal |
| 19:15.18 | brlcad | you should understand this point |
| 19:15.20 | Ch3ck | so i can make some more modifications.. |
| 19:15.38 | brlcad | you should not just hop on IRC, ask a question .. wait a lil bit and leave |
| 19:16.19 | Ch3ck | http://brlcad.org/wiki/User:NyahCh3ck20/Proposal |
| 19:16.28 | brlcad | considered poor etiquette, if you have a question you're expected to ask and wait |
| 19:16.46 | Ch3ck | i just want to know youre thoughts on the recent changes i have made... |
| 19:16.47 | brlcad | if you cannot wait, then you shouldn't be asking on IRC -- use the mailing list |
| 19:16.55 | Ch3ck | yeah |
| 19:17.03 | Ch3ck | i understand.. |
| 19:17.38 | brlcad | you and 20 others want to know .. all proposals get reviewed and re-reviewed several times |
| 19:17.47 | brlcad | have to be patient :) |
| 19:18.11 | Ch3ck | yeah |
| 19:18.14 | brlcad | in the meantime, don't wait for me to tell you what's wrong with it -- improve it yourself or work on something else that helps your proposal |
| 19:18.15 | Ch3ck | i understand.. |
| 19:18.23 | vladbogo | hi |
| 19:18.29 | brlcad | hi vladbogo |
| 19:18.31 | Ch3ck | hi vlad.. |
| 19:19.30 | vladbogo | I looked on the TODO file in libdm and I want to refactor dm-genric.c so that is shouldn't contain #ifdefs |
| 19:20.02 | brlcad | Ch3ck: your proposal reminded me of something |
| 19:20.21 | brlcad | given your recent experience, you should look into our redblack tree to-do |
| 19:20.29 | brlcad | s/should/could/ |
| 19:20.42 | brlcad | you worked on a redblack tree implementation, right? |
| 19:20.54 | Ch3ck | yeah.. |
| 19:21.06 | Ch3ck | even worked on interval trees.. |
| 19:21.25 | vladbogo | i was thinking about starting with the open functions but i don't know which approach is better |
| 19:21.45 | brlcad | Ch3ck: see our TODO file and look for the redblack entry |
| 19:21.52 | Ch3ck | ok |
| 19:21.54 | brlcad | that'd make a good patch/feedback/discussion |
| 19:21.59 | vladbogo | I want to add a new callback function to struct dm that does the actual opening |
| 19:22.51 | brlcad | vladbogo: suggest just attacking one #ifdef (that you can actually test) |
| 19:23.01 | brlcad | that might help give some direction |
| 19:23.52 | brlcad | *_open_existing should be an easy one, but there are others too |
| 19:24.19 | Notify | 03BRL-CAD:carlmoore * 55344 brlcad/trunk/src/util/double-asc.c: change (void) to (), and remove reference to case ?, because we have the default available |
| 19:26.44 | *** join/#brlcad Ch3ck_ (~Ch3ck@41.205.16.70) |
| 19:27.12 | *** join/#brlcad kesha (~kesha@14.139.122.114) |
| 19:27.15 | Ch3ck_ | Sorry for quitting there?? |
| 19:27.23 | Ch3ck_ | my computer has got some probs. |
| 19:28.41 | vladbogo | brlcad: i can't find *open_existing in dm-generic.c should I look somewhere else? |
| 19:28.53 | brlcad | vladbogo: no, stick to the #ifdefs |
| 19:29.46 | Ch3ck_ | hey guys how do i get the previous discussions on irc chat? |
| 19:30.06 | Ch3ck_ | my computer just went off.. facing some technical issues here... |
| 19:32.24 | vladbogo | si I was thinking on adding a new callback to struct dm for *_open_dm, but I saw that the dm_open from dm-generic.c returns the struct dm pointer that will be used, so in order to change this should I change also the way mged uses dm-open? |
| 19:33.24 | vladbogo | Ch3ck_ I activated logging in order to see previous conversations. I don't know if you can access it if you do not have logging active |
| 19:34.19 | Ch3ck_ | ok |
| 19:34.27 | Ch3ck_ | how do i activate it?? |
| 19:35.26 | vladbogo | brlcad: I mean that as I saw in the code there must be a function that selects the dm (that returns struct dm) so I was thinking about making a select function and then make the opening using struct dm. Is this approach ok? |
| 19:35.48 | vladbogo | Ch3ck_: do you use xchat? |
| 19:36.05 | Ch3ck_ | yeah |
| 19:36.10 | Ch3ck_ | on my SL distro.. |
| 19:36.43 | vladbogo | then settings->Preferences->logging and enable logging |
| 19:37.49 | Ch3ck_ | thanks vlad |
| 19:37.54 | Ch3ck_ | did it already?? |
| 19:38.06 | Ch3ck_ | everything looks fine now.. |
| 19:38.11 | vladbogo | you're welcome |
| 19:39.55 | Ch3ck_ | yeah |
| 19:40.04 | Ch3ck_ | brlcad: you there? |
| 19:40.53 | Ch3ck_ | i just wanted to ask what you were talking about with the red black treess. |
| 19:55.07 | starseeker | Ch3ck_: see the TODO file - it should list some redblack tree items |
| 19:55.35 | Notify | 03BRL-CAD:carlmoore * 55345 brlcad/trunk/src/util/double-asc.c: reinstate 'void', and remove single-quotes from Usage, and provide for 'no-argument, no-redirect' case |
| 19:56.02 | Ch3ck_ | starseeker: thanks.. |
| 20:02.00 | *** join/#brlcad cstirk (~quassel@c-71-56-216-45.hsd1.co.comcast.net) |
| 20:06.44 | brlcad | vladbogo: you will almost certainly also need to change mged and how mged works with a DM |
| 20:06.59 | brlcad | that's why I suggested just starting with one/any #ifdef and work to elimiate it |
| 20:07.43 | vladbogo | brlcad: thanks I will start working on it |
| 20:07.57 | brlcad | Ch3ck_: don't ask if I'm here, just ask your questions and someone will eventually respond almost every time (as long as you are here) |
| 20:08.16 | brlcad | that's why we keep saying this: |
| 20:08.17 | brlcad | ~ask |
| 20:08.17 | ibot | Questions in the channel should be specific, informative, complete, concise, and on-topic. Don't ask if you can ask a question first. Don't ask if a person is there; just ask what you intended to ask them. Better questions more frequently yield better answers. We are all here voluntarily or against our will. |
| 20:08.28 | brlcad | "Don't ask if a person is there; just ask what you intended to ask them |
| 20:09.09 | Ch3ck_ | ok |
| 20:09.24 | Ch3ck_ | Just wanted to know what you were talking about concerning redblack trees |
| 20:09.33 | Ch3ck_ | on the todo |
| 20:09.50 | Ch3ck_ | i have not seen any todo on redblack trees |
| 20:10.00 | Ch3ck_ | so could you please give me a pointer to it? |
| 20:10.03 | brlcad | then you're not looking in the right place |
| 20:10.07 | brlcad | or not looking hard enough |
| 20:10.17 | Ch3ck_ | ok |
| 20:10.24 | maths22_ | Ch3ck_: you also can get previous irc conversations (for this channel) at http://ibot.rikers.org/%23brlcad/ |
| 20:10.25 | Ch3ck_ | let me look better.. |
| 20:10.27 | brlcad | do you have a checkout? |
| 20:10.37 | Ch3ck_ | yes. |
| 20:10.43 | brlcad | and you've read the TODO file? |
| 20:10.56 | Ch3ck_ | its long |
| 20:11.09 | Ch3ck_ | so just scanned through to see the redblack trees.. section |
| 20:11.23 | Ch3ck_ | and i did not see any thing.. |
| 20:11.31 | brlcad | why would there be a redblack trees section? |
| 20:11.54 | brlcad | so yes, you just didn't look hard enough |
| 20:12.10 | brlcad | I can't hold your hand on how to read and search a text file :) |
| 20:12.36 | Ch3ck_ | yeah... |
| 20:12.37 | brlcad | you gotta be more self-sufficient than that |
| 20:12.41 | Ch3ck_ | yeah |
| 20:12.46 | Ch3ck_ | i understand.. |
| 20:13.06 | Ch3ck_ | its that we were discussing you did not finish what you were saying.. |
| 20:13.09 | brlcad | so give it another try, and try to understand what it's saying -- use google to research the issue |
| 20:13.19 | brlcad | I did finish :) |
| 20:13.22 | Ch3ck_ | concerning you feedback on my proposal.. |
| 20:13.28 | Ch3ck_ | ok |
| 20:13.40 | Ch3ck_ | thanks would work on it hard.. |
| 20:14.20 | vladbogo | also I told you about a compilation error on Windows and after working a little bit I found out that there are other errors. Between dealing with those errors and the refactoring we just talked about I think that the second one is more important but I would like to know on which do you suggest that I should work on because I don't have time to do both right now? |
| 20:15.09 | brlcad | vladbogo: that's your judgement call to make, not mine |
| 20:15.10 | brlcad | I can't speak to your time availability |
| 20:15.44 | brlcad | fixing compilation errors should be very quick and easy |
| 20:15.57 | brlcad | making a refactoring patch, not so quick and easy |
| 20:16.40 | brlcad | fixing compile errors isn't as impressive / interesting as a refactoring, but then neither is too if they're both incomplete |
| 20:17.02 | brlcad | and if you can't fix a compile error (quickly/easily), that's something to work on improving |
| 20:18.18 | vladbogo | brlcad: thanks for you're help. I will try to make the refactoring patch and submit it as soon as possible |
| 20:19.24 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 20:27.34 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 20:34.48 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 21:22.01 | *** join/#brlcad mpictor (~mark@99-93-104-202.lightspeed.iplsin.sbcglobal.net) |
| 21:29.42 | Notify | 03BRL-CAD:starseeker * 55346 brlcad/trunk/include/config_win_cmake.h.in: Try to set up defines for stat, fstat, fseek, lseek, and ftell that will make the libbu wrappers unnecessary - untested. Will have to be a bit careful backing out r54713 once these are working - a few files show conflicts. |
| 21:31.25 | starseeker | might be tied up with r54922 |
| 21:32.37 | starseeker | urk |
| 21:32.48 | starseeker | regression failure - solids.rt.pix 3 off by many |
| 21:33.58 | starseeker | is betting that's r55337 |
| 21:42.04 | caen23 | starseeker: isn't that an older bug? investigating it was a codein task |
| 21:54.37 | Notify | 03BRL-CAD:r_weiss * 55347 brlcad/trunk/sh/cmp.sh: Fixed a bug in the xray computations. Improved the volume computations. |