| 00:06.21 | CIA-65 | BRL-CAD: 03tbrowder2 * r50752 10/brlcad/trunk/ (regress/vls_vprintf.sh src/libbu/test_vls_vprintf.c): change internal file name to reflect external file name |
| 01:12.47 | CIA-65 | BRL-CAD: 03crdueck * r50753 10/brlcad/trunk/src/mged/animedit.c: the bug with 'joint holds' is related to 'joint solve' crashing as well, both eventually make bad calls to hold_point_location(), edited comment and error message |
| 01:54.27 | brlcad | crdueck: if it's of any help, Tcl_AppendResult(arg1, arg2, arg3, ...) is like std::cout << arg1 << arg2 << arg3; |
| 04:15.01 | *** join/#brlcad ibot (~ibot@rikers.org) |
| 04:15.01 | *** topic/#brlcad is BRL-CAD Open Source Solid Modeling || http://brlcad.org || logs: http://ibot.rikers.org/%23brlcad/ || Congratulations to our 11 accepted GSoC students!! |
| 06:21.32 | *** join/#brlcad ksuzee (~ksuzee91@193.151.107.42) |
| 06:28.43 | *** part/#brlcad ksuzee (~ksuzee91@193.151.107.42) |
| 06:31.53 | *** join/#brlcad Jak_o_Shadows (~Fake@unaffiliated/jak-o-shadows/x-0479135) |
| 06:51.43 | CIA-65 | BRL-CAD: 03Leedsescorts25 07http://brlcad.org * r3766 10/wiki/Main_Page: |
| 06:51.44 | CIA-65 | BRL-CAD: Replacing page with ' |
| 06:51.44 | CIA-65 | BRL-CAD: [http://www.cameronmorgan.co.uk/ sheffield escorts] , |
| 06:51.44 | CIA-65 | BRL-CAD: [http://www.cameronmorgan.co.uk/ escorts in leeds] , |
| 06:51.44 | CIA-65 | BRL-CAD: [http://www.cameronmorgan.co.uk/ escort agency leeds]' |
| 06:51.47 | *** join/#brlcad d_rossberg (~rossberg@BZ.BZFLAG.BZ) |
| 08:05.03 | CIA-65 | BRL-CAD: 03Al Da Best 07http://brlcad.org * r3767 10/wiki/Main_Page: Undo revision 3766 done by someone spamming, or a bot., |
| 08:18.49 | *** join/#brlcad Jak_o_Shadows1 (~Fake@CPE-144-136-211-241.sa.bigpond.net.au) |
| 08:41.12 | *** join/#brlcad stas (~stas@82.208.133.12) |
| 09:23.42 | *** join/#brlcad anuragmurty (~anurag@14.139.128.14) |
| 10:19.59 | *** join/#brlcad anuragmurty (~anurag@14.139.128.14) |
| 12:22.48 | *** part/#brlcad anuragmurty (~anurag@14.139.128.14) |
| 12:44.26 | brlcad | thanks Al_DC_Best |
| 12:45.45 | CIA-65 | BRL-CAD: 03d_rossberg * r50754 10/brlcad/trunk/src/libbu/ (CMakeLists.txt Makefile.am test_ctype.c): apply sourceforge parch 3528073 (test_ctype.patch) from anrgmrty: "A test for ctype.c checking for printable and non-printable strings test_ctype.c" |
| 13:23.25 | *** join/#brlcad Stattrav_ (~Stattrav@61.12.114.82) |
| 13:23.30 | brlcad | d_rossberg: I like the idea of supporing raw voxel data output as a first step for that converter, thoughts? e.g., http://support.echoview.com/WebHelp/Reference/File_formats/Export_file_formats/Volume_data_set_file_formats.htm (.raw) |
| 13:24.16 | brlcad | that happens to be the input format for our vol primitive too |
| 13:24.47 | brlcad | (basically a 3d array of uint8 values) |
| 13:26.23 | brlcad | can easily expand on that to a more dynamic range as the next step, maybe other more efficient output formats after that |
| 13:28.35 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 13:32.23 | d_rossberg | this would require one file for each region, and what contains the uint8? |
| 13:33.27 | d_rossberg | i'm thinking more of "<x-index> <y-index> <z-index> <region-name>" like format |
| 13:34.18 | d_rossberg | this would allow to attach different materials to the different regions in a hydrocode (e.g.) |
| 13:37.02 | *** part/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 13:43.31 | d_rossberg | shouldn't it be src/conf/g-voxel? |
| 13:44.42 | d_rossberg | (sorry: src/conv/g-voxel.c) |
| 13:49.47 | CIA-65 | BRL-CAD: 03brlcad * r50755 10/brlcad/trunk/src/shapes/fence.c: fix a memory corruption error where we incorrectly bu_free() a pointer that was bu_calloc'd but then clobbered after set to mk_addmember result. was causing a crash. |
| 13:52.16 | brlcad | the uint8 is the proportion of material in that voxel cell, so most would be 255 or 0, but edge voxels are proportional with the amount of material in them |
| 13:52.44 | brlcad | ct scan data is commonly like this, representing density within that cell |
| 13:53.13 | brlcad | which is then thresholded with the vol primitive on/off when values are within a given range (e.g. >128) |
| 13:54.11 | brlcad | src/conv/g-voxel.c was one of the suggestions I mentioned in the e-mail |
| 13:54.23 | brlcad | src/conv/g-voxel.c or src/conv/voxel/g-voxel.c |
| 13:55.48 | brlcad | supporting multiple regions would be good, I was thinking that doing output object-agnostic might be a good first step that can be easily hooked into our vol primitive and automatically tested for correctness with the conversion.sh script |
| 13:57.03 | brlcad | following the formats discussion with wu, that's basically the difference between evaluated implicit volumetric data and unevaluated implicit volumetric data (that HIERARCHY option) to work at region level |
| 13:57.38 | brlcad | (actually somewhere in between if you evaluate part-way up to region) |
| 13:58.39 | brlcad | still, the goal was to be able to quickly hook it in for V&V testing to make sure it's right, then he could spend the next month working on supporting other output formats like hydrocode inputs |
| 14:03.49 | d_rossberg | @brlcad: then your suggestion "src/other or src/other/voxel" was a typing error? |
| 14:04.40 | brlcad | oops, 'other' should have been conv, yes |
| 14:04.51 | d_rossberg | ok :) |
| 14:05.34 | brlcad | sends correction |
| 14:16.37 | CIA-65 | BRL-CAD: 03starseeker * r50756 10/brlcad/trunk/src/libbu/Makefile.am: Fix header name |
| 14:19.06 | CIA-65 | BRL-CAD: 03bob1961 * r50757 10/brlcad/trunk/src/tclscripts/lib/cursor.tcl: Yet another Windows specific fix. |
| 14:21.41 | brlcad | ~seen kane_ |
| 14:21.43 | ibot | kane_ <~kane@g226123023.adsl.alicedsl.de> was last seen on IRC in channel #brlcad, 8d 2h 24m 47s ago, saying: 'Is there a name convention for class names?'. |
| 14:21.56 | CIA-65 | BRL-CAD: 03starseeker * r50758 10/brlcad/trunk/src/other/CMakeLists.txt: Generalize the disclean rules for libpng links |
| 14:38.02 | CIA-65 | BRL-CAD: 03brlcad * r50759 10/brlcad/trunk/ (BUGS TODO): need to investigate/fix the mged joints command and migrate it to libged. |
| 14:55.10 | CIA-65 | BRL-CAD: 03starseeker * r50760 10/brlcad/trunk/configure.ac: Need the makefile for raw dir |
| 15:31.31 | CIA-65 | BRL-CAD: 03Phoenix 07http://brlcad.org * r3768 10/wiki/User:Phoenix/GSoc2012/Reports: /* Week 2 */ |
| 15:49.36 | brlcad | Stattrav_: since you do not yet have commit, you should be posting your work at least once a day to the patches tracker |
| 15:49.48 | brlcad | i see the log updates, so there should be plenty to submit, please do this today |
| 15:50.39 | brlcad | one tracker for each file, one for sql one for parser.py, would work fine too so they can be independently reviewed |
| 15:52.49 | Stattrav_ | sure |
| 15:53.12 | Stattrav_ | 4 files as of now |
| 15:54.29 | Stattrav_ | brlcad: I shall do that today itself. I am looking into design of web API today. Was going through Github's gist API and that looks like something we could follow |
| 15:55.23 | brlcad | Stattrav_: I'm more concerned with your lack of commit than with your actual project progress at this point |
| 15:55.45 | brlcad | we need to have code to review in order to grant commit, and you're supposed to be taking steps to help make that easy |
| 15:55.58 | brlcad | this isn't a homework assignment |
| 15:56.29 | Stattrav_ | ohh |
| 15:57.26 | Stattrav_ | I was waiting for the commit access. I am extremely sorry about that. I shall send them in right away |
| 15:57.40 | brlcad | this is stuff that was supposed to be sorted out weeks ago, and has been reiterated numerous times on the mailing list and here... please? :) |
| 15:57.56 | Stattrav_ | i.imgur.com/z9aHy.png <- this is my code structure |
| 15:58.01 | brlcad | you don't wait, you post your work to the patches tracker daily as if THAT was your commit |
| 15:58.24 | Stattrav_ | so I add a patch for each folder individually ? |
| 15:59.22 | brlcad | for your work, even just uploading that as a tarball would have been fine, but submitting the sql and parser and util scripts as separate patches would work too, so they can be independently tracke |
| 15:59.26 | brlcad | *tracked |
| 15:59.34 | Stattrav_ | cool |
| 15:59.44 | brlcad | we don't WANT you to be using the patches tracker -- it's to vet that you understand our HACKING rules and are following them |
| 16:00.03 | Stattrav_ | yup |
| 16:00.24 | brlcad | I can almost guarantee that you code is not compliant if you haven't been reading the e-mails that said to post your code to the patches tracker... :) |
| 16:00.41 | brlcad | there's a lot of details that make for integrated maintainable code |
| 16:01.18 | brlcad | anything you write will be familiar to you, but your code needs to be maintainable and obvious to others too, so it has to be discussed, reviewed, understood, integrated, etc |
| 16:02.57 | Stattrav_ | yup, been following HACKING file |
| 16:03.14 | Stattrav_ | btw was there any mistake w.r.t the patch I submitted ? |
| 16:03.28 | *** join/#brlcad anuragmurty (~anurag@14.139.128.12) |
| 16:05.14 | CIA-65 | BRL-CAD: 03starseeker * r50761 10/brlcad/trunk/src/libbu/Makefile.am: fix LDADD line for test_vls_vprintf |
| 16:25.16 | *** join/#brlcad anuragmurty (~anurag@14.139.128.12) |
| 16:26.40 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 16:26.47 | *** join/#brlcad anuragmurty1 (~anurag@14.139.128.12) |
| 16:27.15 | *** join/#brlcad anuragmurty2 (~anurag@14.139.128.12) |
| 16:28.34 | brlcad | anuragmurty: anuragmurty1: anuragmurty2: what irc client are you using? |
| 16:29.08 | brlcad | you need to change it... the one you're using is terrible, keeps disconnecting and reconnecting |
| 16:30.22 | brlcad | looks like it's pidgin |
| 16:30.25 | anuragmurty2 | brlcad: hi! it is a problem with connection.. |
| 16:30.33 | anuragmurty2 | yes it is.. |
| 16:30.47 | anuragmurty2 | :-| |
| 16:31.08 | brlcad | do you have access to a remote server? |
| 16:34.41 | brlcad | anuragmurty2: if you don't, I suggest getting an ssh account on some public server and using screen+irssi |
| 16:34.52 | brlcad | there's a big list of places that'll give you an ssh account here: http://shells.red-pill.eu/ |
| 16:35.03 | brlcad | that's as good a place as any to start |
| 16:35.16 | brlcad | just make sure they allow screen and irc |
| 16:35.33 | CIA-65 | BRL-CAD: 03Crdueck 07http://brlcad.org * r3769 10/wiki/User:Crdueck/log: |
| 16:35.39 | brlcad | that should stop all the disconnects and keep you logged in 24/7 |
| 16:36.44 | anuragmurty2 | ok..i will do that.. and just one more thing.. i am having sudden trouble with mged.. |
| 16:36.58 | anuragmurty2 | has 3.3, needs 3.4 |
| 16:37.20 | anuragmurty2 | for itk |
| 16:37.25 | brlcad | anuragmurty2: you also need to update your dev log today -- should have entries per day (see http://brlcad.org/wiki/User:Cprecup/GSoC2012_progress for example) |
| 16:37.38 | brlcad | and the past week seems missing |
| 16:38.10 | Stattrav_ | anuragmurty2: I can send you an invit to irccloud if needed |
| 16:38.28 | anuragmurty2 | brlcad : I did update it day before yesterday.. |
| 16:38.34 | anuragmurty2 | Yesterday I could not.. |
| 16:39.00 | brlcad | then it's the odd way you're using numers instead of dates that is confusing |
| 16:39.06 | anuragmurty2 | Stattrav_: sure! thanks |
| 16:39.13 | *** join/#brlcad anuragmurty (~anurag@14.139.128.12) |
| 16:39.15 | brlcad | what is 11 for example |
| 16:39.18 | anuragmurty | anrg: Stattrav_: sure! thanks |
| 16:40.04 | anuragmurty | brlcad: i will make sure i include the dates also now.. |
| 16:40.09 | brlcad | thanks |
| 16:40.39 | brlcad | I trust you got the e-mails too |
| 16:40.46 | anuragmurty | yes.. :) |
| 16:40.51 | brlcad | congratulations, thanks :) |
| 16:40.53 | anuragmurty | thanks a lot |
| 16:41.24 | anuragmurty | :) |
| 16:46.27 | anuragmurty | thanks a ton Stattrav_ |
| 16:46.28 | Stattrav_ | anuragmurty: sent |
| 16:46.50 | anuragmurty | yeah got it.. |
| 16:46.52 | anuragmurty | :) |
| 16:48.08 | CIA-65 | BRL-CAD: 03n_reed * r50762 10/brlcad/trunk/src/other/step/src/express/expparse.y: Allow local variables to have generic types; fixes failure on ap239 express schema. SCL git 254b5a3. |
| 16:50.23 | *** join/#brlcad anrgmrty (u6512@gateway/web/irccloud.com/x-jphjlyjmqpgbgurf) |
| 16:53.10 | *** part/#brlcad anuragmurty (~anurag@14.139.128.12) |
| 16:53.56 | *** part/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 17:00.53 | anrgmrty | hi.. i am rebuilding the brl-cad latest code.. getting some problems running mged... couldn't load file "/usr/lib/libitk3.3.so.1": /usr/lib/libitk3.3.so.1: cannot open shared object file: No such file or directory |
| 17:00.53 | anrgmrty | MGED Aborted. |
| 17:01.07 | brlcad | /usr/lib sounds like the wrong one |
| 17:01.33 | anrgmrty | it says, it needs libitk3.4 .. and it has libitk3.4.so as well.. but why is it searching for 3.3..? |
| 17:04.43 | anrgmrty | <PROTECTED> |
| 17:04.52 | *** join/#brlcad yukonbob (~bch@methodlogic.net) |
| 17:04.55 | yukonbob | hello, #brlcad |
| 17:14.50 | brlcad | anrgmrty: at a glance, it's saying file not found, so you apparently have a /usr/lib/libitk3.3.so.1 symbolic link pointing to a file that does not exist perhaps |
| 17:15.59 | brlcad | if you set BRLCAD_BUNDLED_LIBS=Bundled during cmake, it should avoid using the system version regardless of your system misconfiguration |
| 17:18.55 | anrgmrty | i did use ENABLE_ALL during cmake |
| 17:25.06 | brlcad | did the summary say itcl/itk was going to use system or bundled? |
| 17:29.25 | anrgmrty | Compile Itcl/Itk ......................: ON |
| 17:29.48 | brlcad | do you have LD_LIBRARY_PATH set? |
| 17:30.12 | brlcad | (environment variable) |
| 17:30.56 | anrgmrty | no.. |
| 17:40.09 | anrgmrty | and the thing is- i do the same thing in case i want to build.. i never face a problem of this kind |
| 17:41.30 | brlcad | well there's two problems. if the compile itcl/itk as ON is to be believed, then it using /usr/lib/libitk may be a bug in the build system. |
| 17:41.50 | brlcad | if /usr/lib/libitk.3.3.so.1 is a dead symbolic link, that's a second issue specific to your system that you should fix |
| 17:42.21 | CIA-65 | BRL-CAD: 03tbrowder2 * r50763 10/brlcad/trunk/src/libbu/ (test_vls_vprintf.c vls_internals.h vls_vprintf.c): (log message trimmed) |
| 17:42.22 | CIA-65 | BRL-CAD: This is a major change to vsl_vprintf (and related files) |
| 17:42.22 | CIA-65 | BRL-CAD: incorporating a more modular approach. In general, this change tries |
| 17:42.22 | CIA-65 | BRL-CAD: to separate the parsing of the format string from the handling of the |
| 17:42.22 | CIA-65 | BRL-CAD: result, both for valid as well as for obsolete or unknown parts. The |
| 17:42.22 | CIA-65 | BRL-CAD: approach is also intended to ease maintenance and future enhancements. |
| 17:42.23 | CIA-65 | BRL-CAD: The function specification has also been modified somewhat. |
| 17:42.51 | anrgmrty | there is no symbolic link.. i checked.. |
| 17:49.41 | brlcad | ls -la /usr/lib/libitk3.3.so.1 |
| 17:51.07 | CIA-65 | BRL-CAD: 03tbrowder2 * r50764 10/brlcad/trunk/src/libbu/vls_vprintf.c: removed old test statement, added another error handler |
| 17:53.20 | anrgmrty | brlcad : yes thats how i checked.. there is nothing |
| 17:54.16 | brlcad | yet it's in the output so something points to it |
| 17:54.27 | brlcad | ldd /path/to/mged |
| 17:54.45 | brlcad | then ls -la /path/to/libitk_from_ldd |
| 17:57.10 | anrgmrty | yes, ldd gives /usr/lib/libitk3.4.so.0 as one of the dependencies, and it is present there. |
| 17:57.37 | anrgmrty | not 3.3.. 3.4 |
| 17:58.10 | anrgmrty | but when i run mged i don't understand why it searches for libitk3.3.so.1 |
| 17:58.29 | brlcad | except that's a problem |
| 17:58.38 | brlcad | ldd mged should not list /usr/lib/libitk3.4 |
| 17:59.04 | *** join/#brlcad ksuzee (~ksuzee91@46.149.82.166) |
| 17:59.08 | brlcad | clean out your build, delete your installed brl-cad and try a rebuild -- something is dirty |
| 18:00.18 | brlcad | could be a lot of things and, like you said, it was working so something changed |
| 18:00.27 | brlcad | if a rebuild works, then you messed something up |
| 18:00.39 | brlcad | if a rebuild doesn't work, then someone else maybe messed something up |
| 18:01.32 | brlcad | hi ksuzee |
| 18:02.07 | CIA-65 | BRL-CAD: 03erikgreenwald * r50765 10/brlcad/trunk/sh/ (CMakeLists.txt Makefile.am): move orbit.sh to the installed script set |
| 18:03.17 | *** part/#brlcad ksuzee (~ksuzee91@46.149.82.166) |
| 18:04.28 | anrgmrty | i am on it.. just one more thing when i am checking.. what should it actually list as a dependency? if not /usr/lib/libitk?? |
| 18:04.56 | *** join/#brlcad ksuzee (~ksu@46.149.82.166) |
| 18:05.32 | brlcad | with the default install path, and brl-cad installed, it should be /usr/brlcad/dev-7.21.0/lib/lib... |
| 18:07.07 | ksuzee | hello,Sean! |
| 18:08.05 | ksuzee | I've written about htonf |
| 18:08.25 | ksuzee | I updated it some days ago |
| 18:08.39 | ksuzee | there's inline function noe as you told |
| 18:08.43 | ksuzee | *now |
| 18:12.54 | anrgmrty | brlcad : Build static libraries ................: OFF---in the summary.. is this alright? |
| 18:13.00 | brlcad | ksuzee: https://sourceforge.net/tracker/?limit=25&func=&group_id=105292&atid=640804&submitter=ksuzee&submit=Filter |
| 18:13.07 | brlcad | you have 6 pending... :) |
| 18:13.57 | anrgmrty | brlcad : Build static libraries ................: OFF in the summary,.. is this alright? |
| 18:14.02 | brlcad | hm, for whatever reason, it looks like pending wasn't automatically updated to open -- it's supposed to |
| 18:14.05 | brlcad | anrgmrty: that's fine |
| 18:14.31 | anrgmrty | ok.. |
| 18:14.33 | brlcad | ksuzee: would you update them to "Open" for the ones that are ready to be reviewed again |
| 18:15.43 | ksuzee | ok, I will, of course. I thought it can do admin only =) Also I correted this one -- src/util/picbackgnd.c |
| 18:16.23 | brlcad | if you can't just let me know which ones |
| 18:16.33 | brlcad | (by their number) |
| 18:16.37 | ksuzee | and this -- /fb/orle-fb.c) |
| 18:16.41 | ksuzee | ok, sorry |
| 18:16.46 | brlcad | it's okay :) |
| 18:16.56 | brlcad | don't need to tell me if you can :) |
| 18:17.54 | ksuzee | Yeah |
| 18:18.09 | ksuzee | I can) |
| 18:18.09 | ksuzee | I'll do it now |
| 18:19.38 | ksuzee | There're 3 of them. And I'd like to postone my first patch at all. It was first and it's not right) |
| 18:20.49 | ksuzee | it's a pity, htonf I updated on 20/05..))) |
| 18:21.47 | brlcad | you're doing fine other than not making "clean" progress, there are lots of patches and other things going on |
| 18:22.00 | brlcad | you just keep picking dangerous/tricky code to modify |
| 18:22.20 | brlcad | there's plenty of easy ones, so I think it's just a problem of communication beforehand -- to discuss what is WORTH changing :) |
| 18:22.30 | brlcad | you have no way to know that without asking |
| 18:26.35 | ksuzee | It's just because of absence of experience :)) |
| 18:26.37 | ksuzee | mb) |
| 18:27.08 | ksuzee | I corrected everytrhing |
| 18:27.20 | ksuzee | Now there're only 2 pending) |
| 18:27.35 | brlcad | certainly, but it's 1M+ lines of code, so knowing what code is worth reducing and what must be done very carefully is not something you'd learn quickly |
| 18:28.02 | brlcad | when in doubt, learn what tools use the code you're modifying and test before your change, make your change, then test again to make sure it's still working |
| 18:28.20 | CIA-65 | BRL-CAD: 03erikgreenwald * r50766 10/brlcad/trunk/sh/orbit.sh: fix getopt handling. allow actual execution. minor simplification. |
| 18:29.55 | *** join/#brlcad cristina (~quassel@188.24.69.242) |
| 18:30.02 | brlcad | hi cristina |
| 18:30.10 | cristina | hello brlcad |
| 18:31.18 | ksuzee | I'm trying. And I've alredy do so. But some things are difficult to be tested. I've not understans at once that you should use pix-png after pixbackgnd =)) |
| 18:37.00 | CIA-65 | BRL-CAD: 03n_reed * r50767 10/brlcad/trunk/src/other/step/src/fedex_plus/selects.c: optimize utype_member based on SCL git 27ce560 |
| 18:41.22 | CIA-65 | BRL-CAD: 03erikgreenwald * r50768 10/brlcad/trunk/sh/orbit.sh: Write frames directly to PNG instead of pix followed by pix-png. |
| 18:44.29 | CIA-65 | BRL-CAD: 03erikgreenwald * r50769 10/brlcad/trunk/sh/orbit.sh: improve progress display |
| 19:06.17 | brlcad | ksuzee: you can always ask :) |
| 19:38.04 | CIA-65 | BRL-CAD: 03n_reed * r50770 10/brlcad/trunk/src/other/step/src/fedex_plus/ (classes.c classes_misc.c classes_wrapper.cc): Remove some unneeded functions. SCL git 1faaf69 and 2d7ed17. |
| 19:43.33 | CIA-65 | BRL-CAD: 03erikgreenwald * r50771 10/brlcad/trunk/sh/orbit.sh: update ffmpeg usage for 0.11. add azimuth to animation (the actual orbit part) |
| 19:44.13 | ``Erik | http://youtu.be/TbKyLogvngQ huzzah, wood shader and orbit.sh O.o |
| 19:54.55 | yukonbob | very cool |
| 19:59.01 | brlcad | I think that's the first time I've seen orbit in action, nice |
| 20:04.32 | Stattrav | brlcad: can I submit it as once single patch ? |
| 20:05.08 | brlcad | Stattrav: better to at least submit the sql separately |
| 20:05.14 | ``Erik | hm, looks like I originally did orbit for the marching cubes effort |
| 20:05.36 | brlcad | the point is something quick and easy to review, so we can make sure you're following our conventions, and then get you committing |
| 20:06.28 | brlcad | Stattrav: double-check HACKING and look at our other source files for reference of what we expect to see, header, footer, style, and all |
| 20:06.42 | Stattrav | oh yeah Header I did not add |
| 20:06.46 | brlcad | if you miss something, it just means you have to start over with the next file |
| 20:07.00 | Stattrav | good :P |
| 20:07.03 | brlcad | we can't be chasing you down every commit for every little detail |
| 20:07.10 | brlcad | that's why we go through this process |
| 20:07.24 | Stattrav | yeah |
| 20:07.35 | brlcad | the details often seem minor, but they quickly add up and make for terribly messy code over time |
| 20:07.54 | brlcad | especially when code is revisited years later |
| 20:08.01 | brlcad | consistency is key |
| 20:08.18 | brlcad | be pedantic and double-check HACKING and your files |
| 20:09.37 | Stattrav | but most of the stuff is for C/C++ style. Even though the spacing w.r.t if (predicate) etc should remain the same |
| 20:09.52 | brlcad | most of the intentions still apply |
| 20:10.20 | Stattrav | yup |
| 20:10.35 | Stattrav | doxygen style comments for functions etc have been done |
| 20:10.54 | crdueck | brlcad: i tested the lex patch with 'joint list', and the output is the same as pre-patch, but then i intentionally changed the code so it should be wrong or at the very least produce a different result, but it didnt. so 'joint list' must not test it properly |
| 20:11.29 | brlcad | crdueck: drat .. nice testing though |
| 20:11.33 | crdueck | seeing as the patch depends on some code that isnt working well atm, can i just leave it postponed? |
| 20:11.42 | brlcad | joint load is what should have changed |
| 20:12.28 | crdueck | oh? okay, well in either case, joint load is working fine even with the change since joint list can still find all the right joints |
| 20:12.33 | brlcad | crdueck: it will not take less time to look into and fix/apply/reject later -- on the contrary |
| 20:12.49 | Stattrav | brlcad: could you check this https://gist.github.com/949a477d201848a1167c |
| 20:13.21 | brlcad | it will take more time so I'd rather take it to completion since you spent the time refactoring and it's in context (and sparked a great sidebar on the old joint system) |
| 20:13.45 | brlcad | crdueck: if you just make bu_lex() return without doing anything, does load/list still work? |
| 20:13.55 | crdueck | i'll find out |
| 20:14.43 | brlcad | Stattrav: I could, but that sort of defeats the purpose doesn't it? |
| 20:14.51 | brlcad | you're supposed to check it |
| 20:15.06 | brlcad | if you check it and don't find anything and I do, that's a problem |
| 20:15.20 | brlcad | if you don't check it, that's a problem |
| 20:16.03 | brlcad | only if you check it and I don't find anything when reviewing it as a patch is it good to go |
| 20:16.18 | Stattrav | aah |
| 20:16.27 | brlcad | and if you're wanting more specific feedback, ask a more specific question :) |
| 20:18.10 | brlcad | at a glance, that's a monolithic scrape, not a modular one like was mentioned on the mailing list |
| 20:18.15 | *** join/#brlcad crdueck_ (~cdk@d173-238-127-19.home4.cgocable.net) |
| 20:18.30 | Stattrav | as in ? |
| 20:18.31 | brlcad | which isn't a problem with the code as a patch, but is a design concern |
| 20:18.51 | CIA-65 | BRL-CAD: 03Ksuzee 07http://brlcad.org * r3770 10/wiki/User:Ksuzee/Reports: |
| 20:19.07 | brlcad | as in not modular |
| 20:19.16 | brlcad | re-read the mailing list comments... :) |
| 20:19.35 | *** join/#brlcad crdueck (~cdk@d173-238-127-19.home4.cgocable.net) |
| 20:20.42 | Stattrav | "I would suggest defining all of the fields you're interested in extracting and then individually/specifically parsing just one field at a time. Having a list of regular expressions for each field (in a function) would be useful in and of itself. " |
| 20:20.44 | Stattrav | this ? |
| 20:20.54 | CIA-65 | BRL-CAD: 03Ksuzee 07http://brlcad.org * r3771 10/wiki/User:Ksuzee/Reports: |
| 20:21.34 | crdueck | brlcad: if i make the function return 0 right away, theres no errors with load but list doesnt list anything. so joint load must not be working properly in that case |
| 20:22.36 | Stattrav | given half an hour, I could just modularize it right away |
| 20:23.12 | Stattrav | shall be back with the other code. |
| 20:25.13 | crdueck | brlcad: oh wait, my code refactoring deals with C comments, the files i've been using to test dont have any C comments |
| 20:25.26 | crdueck | i'll test again |
| 20:29.50 | brlcad | Stattrav: think about it like this, conceptually you identify the version of BRL-CAD as something you want to capture from the log -- you write a function that captures the version from the log |
| 20:31.06 | brlcad | later, you notice that there are four or five version numbers printed in the log. they seem to all be the same, but that's certainly something worth validating so you either create a "version validation" function or make validation part of the version function you just wrote |
| 20:31.41 | brlcad | next, you identify the number of physical CPUs as something you want to capture, you write a function to extract that .... and so oon |
| 20:32.26 | brlcad | it's a lot easier to talk about validation and adequate parsing when they're modular |
| 20:32.38 | brlcad | even if you end up taking longer to parse or repeating parsing actions |
| 20:33.16 | brlcad | (of course if you repeat the same bit more than a couple times, that probably belongs in it's own modular function otoo |
| 20:34.38 | brlcad | your parsing should not make global assumptions about information placement (like the last line is always X or the fifth line is always Y), it should "look for it" with some pattern |
| 20:35.51 | brlcad | so if that's going to take more than today to address, still post at least the sql file if not all your files today (since you're supposed to do that daily regardless of progress, not waiting until it's done) |
| 20:36.04 | Stattrav | sure |
| 20:40.36 | Stattrav | brlcad: so this is what I've been working on. https://gist.github.com/6dbb50027168437a8286 |
| 20:50.04 | CIA-65 | BRL-CAD: 03n_reed * r50772 10/brlcad/trunk/src/other/step/src/express/dict.c: Apply SCL git f5a130a. Loosens restriction on dictionary duplicates. |
| 21:00.30 | CIA-65 | BRL-CAD: 03Anuragmurty 07http://brlcad.org * r3772 10/wiki/User:Anuragmurty: /* Development Log */ |
| 21:16.12 | *** join/#brlcad crdueck (~cdk@d173-238-127-19.home4.cgocable.net) |
| 21:26.59 | crdueck | alright, I had to make a small change but bu_lex load correctly with and without C style multiline comments |
| 21:30.46 | Stattrav | brlcad: so changed the code to a modular format. so is this in coherence to what you expect ? |
| 21:33.00 | Stattrav | https://gist.github.com/6dbb50027168437a8286 <- Here I've made the class and then I made this object called parser_obj and I can query each of the required fields as parser_obj.get_brlcad_version() |
| 21:36.15 | *** join/#brlcad Al_Da_Best (~Al_Da_Bes@elvyn-248-109.halls.student.lut.ac.uk) |
| 21:45.49 | cristina | brlcad: I have a question regarding my project. I am going to use Adaptagrams as a graph library and it has a functionality for connector routing in interactive graph editors. what else should Adaptagrams be used for? |
| 22:24.34 | CIA-65 | BRL-CAD: 03starseeker * r50773 10/brlcad/branches/STABLE/ (4263 files in 342 dirs): Merge trunk into STABLE - synced as of r50772. |
| 23:08.29 | brlcad | Stattrav: that's looking much more modular |
| 23:08.56 | brlcad | cristina: that's kind of an open-ended question |
| 23:09.54 | brlcad | why, maybe it should be used to help solve world hunger .. probably not, but maybe |
| 23:10.20 | cristina | :) |
| 23:10.40 | brlcad | starseeker: cool, so we pass all regressions on a couple platforms? |
| 23:11.09 | brlcad | crdueck: small change? patch update? |
| 23:11.28 | crdueck | do you want me to update the patch or just commit? |
| 23:11.37 | Stattrav | brlcad: changed everything now |
| 23:12.17 | cristina | brlcad: as a first functionality, I will use the connector routing and I will look into something else as I get to know the code better |
| 23:12.38 | brlcad | crdueck: you can of course just commit (and close out your patch, assign it to yourself, and note it in the commit log message) |
| 23:12.43 | brlcad | but what was the change? |
| 23:12.52 | brlcad | Stattrav: excellent |
| 23:13.16 | brlcad | Stattrav: submit those two patches, update log, carry on ;) |
| 23:13.44 | Stattrav | brlcad: so now there is a class called parser |
| 23:13.45 | brlcad | cristina: I'm not sure what that means, exactly, but it sounds good ;) |
| 23:14.09 | Stattrav | so one could invoke parser_obj.run() to get the actual process running |
| 23:14.21 | Stattrav | else invoke individual methods |
| 23:14.30 | crdueck | brlcad: there was some issue with trying to do *(++pointer), i just took some of the logic from a while loop condition and moved it out into the body of the loop |
| 23:14.47 | brlcad | Stattrav: that sounds good |
| 23:14.57 | brlcad | though I'll also read it when you say it's ready for review when submitted as a patch ;) |
| 23:15.16 | brlcad | crdueck: ah, so it crashed.. :) |
| 23:15.23 | Stattrav | now there are more folders. The class parser.py and util.py go into the folder libs and the scripts folder has a minor script which invokes the object and gets the things done |
| 23:16.18 | brlcad | crdueck: that's exactly why it warranted testing |
| 23:16.19 | brlcad | that would have been a bug FAR harder to diagnose and debug later on if it were applied |
| 23:16.33 | brlcad | glad to hear it's working now (and the code is easier to read) |
| 23:17.08 | brlcad | Stattrav: remember, easy and quick to review is the goal |
| 23:17.11 | brlcad | not academic closure |
| 23:17.37 | crdueck | brlcad: i agree, i was never against testing before applying haha |
| 23:18.04 | brlcad | once you get a couple good review patches that don't require you to fix/change anything, you'll get commit access and we can follow these changes by simply watching your commits |
| 23:18.10 | brlcad | MUCH more efficient |
| 23:18.52 | brlcad | crdueck: I know.. it's just great when the point is accentuated so relevantly when there is a bug discovered like that |
| 23:19.13 | brlcad | if it just worked, nothing would have been learned |
| 23:19.16 | cristina | brlcad: my conclusion is that this connector has a path along the graph (a poly-line) that routes around certain obstacles in the graph |
| 23:20.05 | brlcad | we learn by making mistakes, injecting bugs .. so the quicker we find them (and learn the cause) the faster we become a better programmers |
| 23:20.23 | brlcad | far easier to inspect/debug/learn when the code is fresh ;) |
| 23:21.04 | brlcad | cristina: hm, I'm familiar with graph theory and still not specifically familiar with what you're even describing.. |
| 23:21.28 | brlcad | I presume some struct/class/interface provided by adaptagrams that you're trying to understand yourself? |
| 23:22.21 | brlcad | or that you're just explaining to me (though I'm not sure the utility until I need to use it, unless there are some serious implications involved that are non-obvious) |
| 23:23.32 | CIA-65 | BRL-CAD: 03crdueck * r50774 10/brlcad/trunk/src/libbu/lex.c: rewrote section to improve readability and remove a goto loop, ws changes |
| 23:25.07 | cristina | brlcad: yes, it is a class in Adaptagrams but the concept of line routing exists elsewhere as well. And yes, I am trying to understand it myself. If you want to have a look at its description, here it is: http://adaptagrams.sourceforge.net/libavoid/class_avoid_1_1_conn_ref.html#details |
| 23:28.29 | Stattrav | brlcad: can I submit something which works(It doesnt break anything around. More methods need to be included) but whose functionality still needs improvement ? |
| 23:36.09 | brlcad | Stattrav: can you? how many times and in how many ways do I have to say you're supposed to?!? |
| 23:37.05 | Stattrav | sorry about that |
| 23:41.52 | brlcad | just state the status when you post |
| 23:42.01 | brlcad | it can be incomplete but ready for review |
| 23:42.38 | brlcad | you could have submitted that main wrapper before it even parsed anything |
| 23:43.03 | brlcad | some open source projects expect a patch to be a complete concept, and in general that's best practice |
| 23:43.34 | brlcad | but we're also using patches as a surrogate to vet commit access -- for that, our commits are not expected to be "complete concepts" |
| 23:44.43 | brlcad | they're always works in progres, so the more commits, the more reviews, the more intention being communicated, the more knowledge sharing occurs, the more valuable and understood that code becomes, the less costly it is to improve and maintain |
| 23:45.02 | brlcad | so for that, smaller and frequent is better |
| 23:45.40 | Stattrav | cool that part which was not working is now working |
| 23:46.27 | brlcad | crdueck: oof, you didn't refer to the patch details in the commit log :/ |
| 23:46.30 | Stattrav | I have a svn diff from the trunk. So you asked me to submit two patches right, I could 'svn rm' some files and add them to the second one ? |
| 23:46.48 | brlcad | crdueck: you're also not ctjctj |
| 23:47.11 | brlcad | Stattrav: you don't need to do that to make two patches |
| 23:48.04 | brlcad | svn diff path/to/first path/to/files > patch1 && svn diff path/to/second > patch2 |
| 23:48.31 | brlcad | just specify the files/dirs you want in each |
| 23:49.18 | Stattrav | sure thanks |
| 23:59.00 | brlcad | crdueck: when you commit code that is associated with any of the sourceforge trackers, you should refer to it in the commit message. usually something like "applies sf patch # 123123 from brlcad (title/summary goes here)" or "fixes sf bug # 321321 from crdueck (fixed mged joint crash)" etc |
| 23:59.16 | brlcad | for future reference |